fix(ui): show sun icon in light mode theme toggle#434
Open
KushalLukhi wants to merge 1 commit intoritz078:masterfrom
Open
fix(ui): show sun icon in light mode theme toggle#434KushalLukhi wants to merge 1 commit intoritz078:masterfrom
KushalLukhi wants to merge 1 commit intoritz078:masterfrom
Conversation
|
@KushalLukhi is attempting to deploy a commit to the ritesh-oss Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use a mode-specific icon in the theme toggle button:
moonin dark modesunin light modeCloses #423
Why
The toggle always displayed a moon icon, which made light mode less clear visually.
Change
In
pages/_app.tsx, theIconButtonicon is now conditional onisDarkMode:This keeps the UI consistent with the current theme state.