feat(rivetkit): actor tracing, invocation metrics, and log correlation with otel - #5674
Open
eersnington wants to merge 21 commits into
Open
feat(rivetkit): actor tracing, invocation metrics, and log correlation with otel#5674eersnington wants to merge 21 commits into
eersnington wants to merge 21 commits into
Conversation
Author
|
at the behest of the living tribunal of code reviews, a codiff walkthrough has been bestowed upon you https://codiff.eers.dev/w/JRyyW8zaCbTaFzZuW2l2lHu_ edit: outdated |
eersnington
marked this pull request as ready for review
September 5, 2026 20:16
eersnington
force-pushed
the
stack/feat-rivetkit-actor-telemetry
branch
from
September 6, 2026 19:06
677e734 to
4cd3163
Compare
eersnington
marked this pull request as draft
September 6, 2026 22:02
eersnington
force-pushed
the
stack/feat-rivetkit-actor-telemetry
branch
from
September 7, 2026 15:13
4cd3163 to
4f5b976
Compare
Author
|
A few things now with 4f5b976
|
eersnington
force-pushed
the
stack/feat-rivetkit-actor-telemetry
branch
3 times, most recently
from
September 7, 2026 22:08
cd79754 to
c48a93a
Compare
eersnington
marked this pull request as ready for review
September 8, 2026 15:32
eersnington
force-pushed
the
stack/feat-rivetkit-actor-telemetry
branch
2 times, most recently
from
September 9, 2026 21:02
b7db93f to
7e876b7
Compare
Author
|
Changes with 7e876b7
|
eersnington
force-pushed
the
stack/feat-rivetkit-actor-telemetry
branch
from
September 10, 2026 16:45
7e876b7 to
ca15083
Compare
Author
|
Changes with ca15083
|
eersnington
commented
Sep 10, 2026
| @@ -0,0 +1,5 @@ | |||
| { | |||
Author
There was a problem hiding this comment.
added this to mark spans where an sqlite query or actor call started, but no result was recorded. this will now stand out in user's traces too.
it doesn’t mean the operation failed. this error is used only in tracing and isn’t returned to callers
eersnington
force-pushed
the
stack/feat-rivetkit-actor-telemetry
branch
2 times, most recently
from
September 10, 2026 22:46
4dd4434 to
35f517f
Compare
Author
|
upcoming, public docs |
eersnington
force-pushed
the
stack/feat-rivetkit-actor-telemetry
branch
from
September 11, 2026 13:29
35f517f to
3bba9f6
Compare
eersnington
force-pushed
the
stack/feat-rivetkit-actor-telemetry
branch
from
September 11, 2026 21:15
3bba9f6 to
7c0426b
Compare
eersnington
force-pushed
the
stack/feat-rivetkit-actor-telemetry
branch
from
September 11, 2026 23:41
7c0426b to
a49d62a
Compare
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People of Rivet, this change adds built-in support for OpenTelemetry to Rivetkit for making it easy for users to observe every actor action, scheduled actor action, actor to actor calls, and SQLite operations with relevant trace context and ray identifier.
More in depth:
(To maintain the sanctity of this codebase's contribution guidelines)
Type of change
How Has This Been Tested?
Checklist: