Skip to content

chore: add The Company Company environment config - #5686

Open
NathanFlurry wants to merge 1 commit into
mainfrom
chore/company-environment
Open

chore: add The Company Company environment config#5686
NathanFlurry wants to merge 1 commit into
mainfrom
chore/company-environment

Conversation

@NathanFlurry

Copy link
Copy Markdown
Member

Adds .company/environment.json so The Company Company can build and run this repo in cloud environments.

  • install: native build deps (cmake, libclang, libpq, OpenSSL), Node 22 via NodeSource, pnpm via corepack, Rust 1.91.1 (matches the engine-builder base image) with rustfmt + clippy, pnpm install --frozen-lockfile, cargo fetch --locked
  • prepare: fast idempotent reconcile, pnpm install --frozen-lockfile + cargo fetch --locked (~11s when unchanged)
  • start: frontend dashboard dev server (pnpm --dir frontend dev, port 43708)
  • env: RUSTFLAGS=--cfg tokio_unstable and CARGO_NET_GIT_FETCH_WITH_CLI=true matching Rust CI, plus non-interactive corepack

Verified by running the install command to exit 0 in a clean Ubuntu 24.04 sandbox.

@the-company-company

Copy link
Copy Markdown

Co · session: Set up cloud environment configs for 5 repos

  • Auto-fix ; feedback on this pull request flows to the session and gets addressed
  • Review ; Co reviews new pushes

@co <ask> hands Co a task · @co mute pauses · @co archive ends the session

@railway-app

railway-app Bot commented Sep 9, 2026

Copy link
Copy Markdown

🚅 Deployed to the actors-pr-5686 environment in rivet-frontend

Service Status Web Updated
frontend-cloud 😴 Sleeping (View Logs) Web Sep 10, 2026 at 12:02 am UTC
kitchen-sink 😴 Sleeping (View Logs) Web Sep 10, 2026 at 12:01 am UTC
frontend-inspector 😴 Sleeping (View Logs) Web Sep 9, 2026 at 11:58 pm UTC
ladle ✅ Success (View Logs) Web Sep 9, 2026 at 11:55 pm UTC
mcp-hub ✅ Success (View Logs) Web Sep 9, 2026 at 11:53 pm UTC
website ❌ Build Failed (View Logs) Web Sep 9, 2026 at 11:52 pm UTC

@the-company-company the-company-company Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found

Reviewed commit 4253af4.

@claude

claude Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review

This adds .company/environment.json to let The Company Company build/run this repo in cloud environments. It's a small, self-contained config file with no application logic, so most of the usual code-quality/test-coverage checks don't really apply — a few observations below.

Consistency checks (good):

  • Rust toolchain 1.91.1 matches docker/engine/Dockerfile's RUST_TOOLCHAIN arg.
  • RUSTFLAGS: --cfg tokio_unstable matches the top-level env in .github/workflows/rust.yml.
  • Node 22 matches the version used in .github/workflows/frontend.yml / swift.yml.

Minor points worth considering:

  1. Unpinned upstream install scripts. curl ... deb.nodesource.com/setup_22.x | sudo -E bash - and curl ... sh.rustup.rs | sh -s -- ... both pipe a remote script straight into a privileged/unprivileged shell with no checksum/signature verification. This is standard practice for these installers and not a new risk this PR introduces, but since this only runs in a sandboxed cloud build environment (not production infra), it's likely an acceptable tradeoff — just flagging for awareness rather than blocking.
  2. sudo ln -sf "$HOME"/.cargo/bin/* /usr/local/bin/ — this symlinks the entire rustup-installed toolchain (cargo, rustc, rustfmt, clippy-driver, etc.) into /usr/local/bin, ahead of anything else that might already be on PATH there. Given this is a fresh cloud sandbox this is probably fine, but worth double-checking it doesn't shadow a different toolchain some other step expects.
  3. Node install isn't version-locked beyond the major. setup_22.x will pull whatever the latest Node 22.x is at install time, so the environment isn't fully reproducible across rebuilds. Probably acceptable for a dev/build sandbox, but could drift from whatever engines.node (>=20) or CI actually pins if either changes later.
  4. start only launches the frontend dev server (pnpm --dir frontend dev, port 43708 per CLAUDE.md) — there's no start/build path that boots the engine or runs Rust tests. That seems intentional given the PR description's scope (dashboard dev loop), just confirming it's not an oversight if the intent was broader.

No security, correctness, or test-coverage concerns beyond the above — this is infrastructure/tooling config, not shipped product code, and the described verification (clean Ubuntu 24.04 sandbox install exits 0) is a reasonable check for this kind of change.

🤖 Generated with Claude Code

@the-company-company

Copy link
Copy Markdown

On point 4: intentional. The engine's dev dependencies (FoundationDB, NATS) come up through docker-compose, which is not available in the cloud sandbox, so start is scoped to the dashboard dev server. Points 1-3 are accepted tradeoffs for a sandboxed build snapshot: Node 22 matches CI and Rust 1.91.1 matches the engine-builder base image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant