feat(frontend): add durable streams service to onboarding and namespace settings - #5688
feat(frontend): add durable streams service to onboarding and namespace settings#5688NicholasKissel wants to merge 2 commits into
Conversation
|
🚅 Deployed to the actors-pr-5688 environment in rivet-frontend
|
| export function NamespaceServicesContent() { | ||
| const dataProvider = useEngineCompatDataProvider(); | ||
| const { data: builds = [] } = useInfiniteQuery( | ||
| dataProvider.buildsQueryOptions(), |
There was a problem hiding this comment.
🟠 Medium · Connected status ignores services beyond the first build page
buildsQueryOptions() is an infinite query with a page size of 10, but this component neither prefetches all pages nor calls fetchNextPage. Its selected builds value therefore only contains the first page. In namespaces with more than 10 actor names, a registered durableStream name on a later cursor page is reported as “Not connected.”
Fetch all pages for this membership check, or add a targeted actor-name existence query rather than deriving it from the first page.
ReviewNicely scoped feature addition — the "Services" concept is threaded consistently through the product picker, onboarding stepper, and settings drawer, and the new agent prompt has solid test coverage in Findings1. export function useDurableStreamsServiceUrl(): string | undefined {
const namespace = useEngineCompatDataProvider().engineNamespace;
if (!features.compute) return undefined;
return getDurableStreamsServiceUrl(getRivetRunUrl(namespace));
}
This is also inconsistent with how the rest of this same PR draws the cloud/OSS line: 2. "Connected" detection hardcodes an external package's internal actor name with no shared source of truth ( const SERVICES = [
{
product: getProduct("durable-streams"),
actorNames: ["durableStream"],
},
];The dashboard's only signal for "is Durable Streams connected to this namespace" is whether an actor build literally named Minor
🤖 Generated with Claude Code |
Follow-up to #5633.