Skip to content

fix(gasoline): bound dead-workflow backfill reads #5707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brittianwarner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(gasoline): bound dead-workflow backfill reads #5707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,8 @@ When the user asks to track something in a note, store it in `~/.agents/notes/`

## Performance

- Bound UniversalDB ranges before materialization; a stream consumer's item limit does not constrain RocksDB's eager range allocation. See [dead-workflow backfill](docs-internal/engine/gasoline-dead-workflow-backfill.md).

- Use `rivet_perf::{perf_start, perf_finish}` for latency-sensitive async phases, shared I/O wrappers, and suspected backpressure points where slow-tail spans are useful.
- Keep `perf_start!` labels bounded for metrics; put high-cardinality values such as IDs, request paths, and byte counts in span fields instead.
- Every `PerfMeasure` must end with `perf_finish!` or `perf_abandon!` before leaving scope.
Expand Down
Loading