Add viewport intersection check to cull invisible GraphView edges

[andersendsa]

Your checklist for this pull request

• I've read the guidelines for contributing to this repository
• I made sure to follow the project's coding style
• I've updated the documentation with the relevant information (if needed)
• I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

Test plan (required)

1. Open a large statically-linked binary in Cutter.
2. Navigate to a complex function with hundreds of basic blocks and open the Graph View.
3. Pan and zoom around the graph extensively.
4. Correctness check: Verify that all edges entering or exiting the visible screen area are drawn correctly and no connecting lines are missing.
5. Performance check: Observe the UI responsiveness; panning and zooming should feel smoother and consume less CPU, as off-screen edges are no longer being processed by the Qt painting engine.

Closing issues

[wargio]

normally we require for these a recording of before and after the fix, also what is the issue that is fixing?

[andersendsa]

normally we require for these a recording of before and after the fix, also what is the issue that is fixing?

Hi @wargio this resolves a todo mentioned in the codebase

[andersendsa]

Hi @PremadeS could you pls let me know if there any changes needed or if this pr is good to merge

[PremadeS]

Doesn't seem to be drawing all of the edges correctly

for example on the ls binary inside fcn.000065f0 function

Original: see the false/red and true/green "straight" arrows going to next blocks

This PR: those arrows are no longer present, even though the edges/arrows are in the visible range

Another one from a test binary of mine:
Original: see the true/green straight edge going from first block to next

This PR: It's no longer present

[PremadeS]

From that single addition there seems to be an ~83.45% decrease in time taken (or ~6.04 times faster) for rendering entire graph view with around 7014 edges where ~8 edges are currently visible (8 visible edges is a realistic scenario) on my machine

That is assuming it draws all edges correctly

7014 edges in a graph view at once is highly unlikely in any realistic scenario, this was just to check the difference in performance if there happen to be ~7000 edges

[andersendsa]

@PremadeS i reverted the changes the pr is ready for review

[PremadeS]

Works fine, just need to update the comment :)

[andersendsa]

Hi @PremadeS I have updated the comment the pr is ready for review

[andersendsa]

Hi @PremadeS is this pr good to merge?

[PremadeS]

@andersendsa could you please rebase?

sorry for not merging this sooner, was waiting for the 2.5 release

[andersendsa]

Hi @PremadeS I have updated the base branch