Prototype for an RzIL based analysis chain

.github/labeler.yml

@@ -165,6 +165,11 @@ RzSocket:
   - any-glob-to-any-file:
     - librz/socket/**/*
 
+RzInquiry:
+- changed-files:
+  - any-glob-to-any-file:
+    - librz/inquiry/**/*
+
 RzSyscall:
 - changed-files:
   - any-glob-to-any-file:

librz/arch/analysis.c

@@ -986,6 +986,77 @@ RZ_API bool rz_analysis_op_is_call(RZ_NONNULL const RzAnalysisOp *op) {
 	return false;
 }
 
+/**
+ * \brief Checks if \p op changes the control flow.
+ * It checks op->type, op->eob for it. So any jump, call, trap, or illegal
+ * instruction.
+ * It also returns true for conditional instructions.
+ *
+ * \return True if \p op changes the control flow. False otherwise.
+ */
+RZ_API bool rz_analysis_op_changes_control_flow(RZ_NONNULL const RzAnalysisOp *op) {
+	rz_return_val_if_fail(op, false);
+	switch (op->type & RZ_ANALYSIS_OP_TYPE_MASK) {
+	case RZ_ANALYSIS_OP_TYPE_JMP:
+	case RZ_ANALYSIS_OP_TYPE_UJMP:
+	case RZ_ANALYSIS_OP_TYPE_RJMP:
+	case RZ_ANALYSIS_OP_TYPE_IJMP:
+	case RZ_ANALYSIS_OP_TYPE_IRJMP:
+	case RZ_ANALYSIS_OP_TYPE_CJMP:
+	case RZ_ANALYSIS_OP_TYPE_RCJMP:
+	case RZ_ANALYSIS_OP_TYPE_MJMP:
+	case RZ_ANALYSIS_OP_TYPE_MCJMP:
+	case RZ_ANALYSIS_OP_TYPE_UCJMP:
+	case RZ_ANALYSIS_OP_TYPE_CALL:
+	case RZ_ANALYSIS_OP_TYPE_UCALL:
+	case RZ_ANALYSIS_OP_TYPE_RCALL:
+	case RZ_ANALYSIS_OP_TYPE_ICALL:
+	case RZ_ANALYSIS_OP_TYPE_IRCALL:
+	case RZ_ANALYSIS_OP_TYPE_CCALL:
+	case RZ_ANALYSIS_OP_TYPE_UCCALL:
+	case RZ_ANALYSIS_OP_TYPE_RET:
+	case RZ_ANALYSIS_OP_TYPE_CRET:
+	case RZ_ANALYSIS_OP_TYPE_ILL:
+	case RZ_ANALYSIS_OP_TYPE_UNK:
+	case RZ_ANALYSIS_OP_TYPE_TRAP:
+	case RZ_ANALYSIS_OP_TYPE_SWI:
+	case RZ_ANALYSIS_OP_TYPE_CSWI:
+	case RZ_ANALYSIS_OP_TYPE_LEAVE:
+	case RZ_ANALYSIS_OP_TYPE_SWITCH:
+		return true;
+	default:
+		return false;
+	}
+}
+
+/**
+ * \brief Returns true if the \p op is a direct call.
+ */
+RZ_API bool rz_analysis_op_is_direct_call(RZ_NONNULL const RzAnalysisOp *op) {
+	rz_return_val_if_fail(op, false);
+	switch (op->type & RZ_ANALYSIS_OP_TYPE_MASK) {
+	case RZ_ANALYSIS_OP_TYPE_CALL:
+	case RZ_ANALYSIS_OP_TYPE_CCALL:
+		return true;
+	default:
+		return false;
+	}
+}
+
+/**
+ * \brief Returns true if the \p op is a direct call.
+ */
+RZ_API bool rz_analysis_op_is_direct_jump(RZ_NONNULL const RzAnalysisOp *op) {
+	rz_return_val_if_fail(op, false);
+	switch (op->type & RZ_ANALYSIS_OP_TYPE_MASK) {
+	case RZ_ANALYSIS_OP_TYPE_JMP:
+	case RZ_ANALYSIS_OP_TYPE_CJMP:
+		return true;
+	default:
+		return false;
+	}
+}
+
 RZ_API void rz_analysis_purge(RzAnalysis *analysis) {
 	rz_analysis_hint_clear(analysis);
 	rz_interval_tree_fini(&analysis->meta);

librz/arch/fcn.c

@@ -1854,6 +1854,30 @@ RZ_API RzAnalysisFunction *rz_analysis_get_function_byname(RzAnalysis *a, const
 	return NULL;
 }
 
+/**
+ * \brief Adds a basic block to the RzAnalysis.
+ * It disassembles it to determine the instructions and their offset.
+ */
+RZ_API bool rz_analysis_add_bb(RzAnalysis *a, ut64 addr, ut64 size) {
+	rz_return_val_if_fail(a && size > 0, false);
+	if (size > a->opt.bb_max_size) {
+		RZ_LOG_ERROR("Cannot allocate such big bb of %" PFMT64d " bytes at 0x%08" PFMT64x "\n", (st64)size, addr);
+		rz_warn_if_reached();
+		return false;
+	}
+	RzAnalysisBlock *block = rz_analysis_get_block_at(a, addr);
+	if (block) {
+		rz_analysis_delete_block(block);
+	}
+
+	block = rz_analysis_create_block(a, addr, size);
+	if (!block) {
+		return false;
+	}
+	rz_analysis_block_analyze_ops(block);
+	return true;
+}
+
 /* rename RzAnalysisFunctionBB.add() */
 RZ_API bool rz_analysis_fcn_add_bb(RzAnalysis *a, RzAnalysisFunction *fcn, ut64 addr, ut64 size, ut64 jump, ut64 fail) {
 	if (size == 0) {

librz/arch/isa/hexagon/hexagon_il.c

@@ -228,7 +228,7 @@ static RZ_OWN RzILOpEffect *hex_pkt_to_il_seq(HexPkt *pkt) {
 		rz_pvector_clear(pkt->il_ops);
 		// We need at least the instruction op and the packet commit.
 		// So if there aren't at least two ops something went wrong.
-		RZ_LOG_WARN("Invalid il ops sequence! There should be at least two il ops per packet.\n");
+		RZ_LOG_WARN("Invalid il ops sequence! There should be at least two il ops per packet. pkt_addr = 0x%" PFMT32x "\n", pkt->pkt_addr);
 		return NULL;
 	}
 	RzILOpEffect *complete_seq = EMPTY();