Skip to content

Split tricore and riscv build condition in librz/arch/meson.build, allowing different minimum capstone versions#5938

Merged
notxvilka merged 1 commit into
rizinorg:devfrom
moste00:build_tricore_capstone
Feb 18, 2026
Merged

Split tricore and riscv build condition in librz/arch/meson.build, allowing different minimum capstone versions#5938
notxvilka merged 1 commit into
rizinorg:devfrom
moste00:build_tricore_capstone

Conversation

@moste00

@moste00 moste00 commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

The recent RISC-V PR #5482 accidentally made tricore's build condition too strict, as it needed RISC-V's condition to be tightened to only build on v6 and next (excluding v4 and v5) and tricore was bundled with it under the same condition.

This broke no test but it's unnecessary, this PR restores the build condition of tricore to all versions of Capstone again.

Test plan

...

Closing issues

...

@codecov

codecov Bot commented Feb 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.83%. Comparing base (4c3230c) to head (c8f4354).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3230c...c8f4354. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notxvilka
notxvilka merged commit 6a9eef6 into rizinorg:dev Feb 18, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants