Skip to content

Enhance milstd1750 analysis#6557

Open
godcodehunter wants to merge 29 commits into
rizinorg:devfrom
godcodehunter:enhance-milstd1750-analysis
Open

Enhance milstd1750 analysis#6557
godcodehunter wants to merge 29 commits into
rizinorg:devfrom
godcodehunter:enhance-milstd1750-analysis

Conversation

@godcodehunter

@godcodehunter godcodehunter commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

Usage of AI tools
For this pull request, Claude Code was used, with most of the code generated using the work declaration.

First, I asked for a table of missing parts of the analysis. Then, I got acquainted with what each part does, next I generated most of the code, step by step, verifying its correctness.

...

Test plan

...

Closing issues

...

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.75000% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.98%. Comparing base (478117d) to head (752576f).
⚠️ Report is 31 commits behind head on dev.

Files with missing lines Patch % Lines
librz/arch/p/analysis/analysis_milstd1750.c 87.71% 29 Missing and 20 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
librz/arch/isa/milstd1750/milstd1750_disas.c 81.61% <100.00%> (-0.09%) ⬇️
librz/arch/p/analysis/analysis_milstd1750.c 89.14% <87.71%> (+0.77%) ⬆️

... and 78 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 478117d...752576f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@godcodehunter
godcodehunter marked this pull request as ready for review June 28, 2026 12:56
Comment thread librz/arch/p/analysis/analysis_milstd1750.c Outdated
@godcodehunter
godcodehunter force-pushed the enhance-milstd1750-analysis branch from 4d9c44a to 733e8fd Compare June 28, 2026 14:41
@wargio

wargio commented Jun 28, 2026

Copy link
Copy Markdown
Member

please always declare which AI/LLM model have you used for this and how it is helping you.

@godcodehunter

Copy link
Copy Markdown
Contributor Author

please always declare which AI/LLM model have you used for this and how it is helping you.

Ok got it

@wargio wargio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some tests

@notxvilka notxvilka added this to the 1.0.0 milestone Jul 1, 2026
@notxvilka
notxvilka requested a review from wargio July 1, 2026 16:24
Comment thread test/db/analysis/milstd1750 Outdated
Comment thread librz/arch/p/analysis/analysis_milstd1750.c Outdated
Comment thread librz/arch/p/analysis/analysis_milstd1750.c Outdated
Comment thread librz/arch/p/analysis/analysis_milstd1750.c Outdated
Comment thread librz/arch/p/analysis/analysis_milstd1750.c Outdated
Comment thread librz/arch/p/analysis/analysis_milstd1750.c
Comment thread librz/arch/p/analysis/analysis_milstd1750.c Outdated
@notxvilka notxvilka added the waiting-for-author Used to mark PRs where more work is needed label Jul 4, 2026
Comment thread librz/arch/p/analysis/analysis_milstd1750.c Outdated
Comment thread librz/arch/p/analysis/analysis_milstd1750.c Outdated
Comment thread librz/arch/p/analysis/analysis_milstd1750.c Outdated
Comment thread librz/arch/p/analysis/analysis_milstd1750.c
Comment thread librz/arch/p/analysis/analysis_milstd1750.c Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants