Skip to content

Update rz_config list variables to set variables#6623

Open
Farhan-25 wants to merge 6 commits into
rizinorg:devfrom
Farhan-25:config_var_list_to_set
Open

Update rz_config list variables to set variables#6623
Farhan-25 wants to merge 6 commits into
rizinorg:devfrom
Farhan-25:config_var_list_to_set

Conversation

@Farhan-25

Copy link
Copy Markdown
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

This PR:
--> Changes list variables to set variables in config.
--> This change was required as actually the working of those variables were similar to sets only but we were using lists.
--> As sets support unique values this change prevents duplicate options.
Note : AI was used here just to find the required files to fix this issue.
...

Test plan
Unit tests are updated as required.

...

Closing issues

closes #6310

...

@Farhan-25
Farhan-25 marked this pull request as ready for review July 16, 2026 11:46
@wargio

wargio commented Jul 19, 2026

Copy link
Copy Markdown
Member
stderr:
test_config: ../librz/util/set.c:123: rz_set_s_size: Assertion `set' failed.

@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.35294% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.01%. Comparing base (4d7ca41) to head (a443e95).
⚠️ Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
librz/config/config.c 51.81% 40 Missing and 13 partials ⚠️
librz/core/cconfig.c 79.59% 8 Missing and 2 partials ⚠️
librz/config/hold.c 0.00% 5 Missing and 2 partials ⚠️
librz/util/set.c 46.15% 3 Missing and 4 partials ⚠️
librz/core/tui/config.c 0.00% 6 Missing ⚠️
librz/core/carch.c 70.00% 3 Missing ⚠️
librz/core/cautocmpl.c 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
librz/config/config_internal.h 100.00% <ø> (ø)
librz/config/old_config.c 63.34% <100.00%> (ø)
librz/include/rz_config.h 100.00% <ø> (ø)
librz/core/cautocmpl.c 48.74% <85.71%> (+0.24%) ⬆️
librz/core/carch.c 74.84% <70.00%> (+0.70%) ⬆️
librz/core/tui/config.c 0.00% <0.00%> (ø)
librz/config/hold.c 59.16% <0.00%> (+2.36%) ⬆️
librz/util/set.c 71.08% <46.15%> (-1.78%) ⬇️
librz/core/cconfig.c 80.65% <79.59%> (+0.18%) ⬆️
librz/config/config.c 51.39% <51.81%> (-0.34%) ⬇️

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7ca41...a443e95. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch from lists to sets in config variables

2 participants