Through Being Cool - Keys Upgrade - #301
Open
Stockugan wants to merge 33 commits into
Open
Conversation
Contributor
|
Make sure to run your midi through magma, it picked up a few bad midi notes in the BRE for expert PK. |
Contributor
Author
|
the guitar track has slightly longer BRE sustains than the other instruments, not sure what to do there :p |
Contributor
|
Just adjust the guitar BRE to match the others to pass magma. Your keys BRE was charted fine, HMX always has some weird mistakes in their charts but they end up working fine in game. |
Contributor
|
The LH chart needs a bit of work, some of these notes should be sustains held for the full measure notably at M21-M26, and there is a missing note at M26. The repeating sections throughout the song will also need to be fixed. Also I would move the repeating E2/A2 notes to the RH track these sounds like a RH part. |
Contributor
Author
|
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chords in this song were tricky to fit into the ranges, turned out good after a few revisions