The Killing Jar - keys upgrade - #332
Open
SonicSBL wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bet you didn't expect me to do another one of these, did you? Well, after getting RB Unplugged, I found some more songs to add to my collection, and this one was missing keys, so I decided to upgrade it.
While playtesting this, I realized that RBHP had already done a keys upgrade, but its metadata wasn't added to Deluxe, just the MIDI. My guess is because it was by an unknown author. But I think this version is mostly the same except for the trainers and venue.
Speaking of which, I used Aloquendiar's version of Nautilus to clean the original venue, then updated it according to the new information. I also left the fog events in despite Magma complaining about them. Let me know if I should remove them or do anything else.