Skip to content

feat(dfu): add cargo make bin task for rp2040/pico_w/nrf52840 templates - #20

Merged
HaoboGu merged 2 commits into
rmk-rs:mainfrom
Schievel1:embassy-boot
Jul 3, 2026
Merged

feat(dfu): add cargo make bin task for rp2040/pico_w/nrf52840 templates#20
HaoboGu merged 2 commits into
rmk-rs:mainfrom
Schievel1:embassy-boot

Conversation

@Schievel1

Copy link
Copy Markdown
Contributor

adds cargo make bin to rp2040/ pico targets.

See rmk-rs/rmk#877

@Schievel1
Schievel1 marked this pull request as draft June 9, 2026 17:44
@Schievel1

Copy link
Copy Markdown
Contributor Author

Maybe we should rather add the cargo make bin task for everything? let me know what you think.

@HaoboGu

HaoboGu commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

I prefer to add it to only rp2040 examples.

@Schievel1
Schievel1 marked this pull request as ready for review June 11, 2026 20:00
@Schievel1 Schievel1 changed the title feat: add cargo make bin task for rp2040/pico_w templates feat(dfu): add cargo make bin task for rp2040/pico_w templates Jun 12, 2026
Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
@Schievel1

Copy link
Copy Markdown
Contributor Author

Since USB DFU also works for nrf52840 now, I added the bin tasks to the templates of this one as well.

@Schievel1 Schievel1 changed the title feat(dfu): add cargo make bin task for rp2040/pico_w templates feat(dfu): add cargo make bin task for rp2040/pico_w/nrf52840 templates Jun 19, 2026
@HaoboGu
HaoboGu merged commit 0a3f9b5 into rmk-rs:main Jul 3, 2026
14 checks passed
@Schievel1
Schievel1 deleted the embassy-boot branch July 3, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants