fix: name split esp32 firmware images after the keyboard - #24
Merged
Conversation
Split esp32 templates merged to hardcoded central.bin/peripheral.bin,
unlike the {{ project_name }}-central.uf2 convention of other split
templates. Use {{ project_name }}-central/peripheral.bin instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split esp32 templates (c3/c6/s3/h2) merged espflash images to hardcoded
central.bin/peripheral.bin, so users building several keyboards get indistinguishable files. Other split templates already follow the{{ project_name }}-central.uf2convention, and non-split esp32 templates use{{ project_name }}.bin; this aligns the split esp32 templates with them. rmkit substitutes{{ project_name }}in all.tomlfiles, soMakefile.tomlis covered.Reported by @peterjc in https://github.com/peterjc/rmk-pico-keyboards/actions/runs/28672157097/job/85037673964 (esp32h2). Companion workflow fix that actually uploads esp32
.binartifacts: rmk-rs/rmk#903Verified locally: generated a project from the updated esp32h2_split template (mimicking rmkit substitution) and ran
cargo make uf2 --release— producedFly_Half_ESP32H2-central.binandFly_Half_ESP32H2-peripheral.bin.