fix(wasm): unlock before listening for topics - #953
Closed
HaoboGu wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Delay the demo's topic listener until the unlock ceremony has completed. Already-unlocked and permanently locked devices still start the listener immediately.
Why
On a normally locked device, the demo started
next_event()and then exposed the unlock button. The pending wasm-bindgen call keeps a mutable borrow of the Rust client, so clicking Unlock re-enters the same object and traps withrecursive use of an object detected.Root cause
The same
WasmClientwas used concurrently by the indefinitely pending topic pump and the unlock request sequence.Impact
This only changes demo sequencing. Protocol and firmware behavior are unchanged.
Checks
node --input-type=module --check.Built on #848.