fix(wasm): release Web Serial locks on close - #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Release the Web Serial reader and writer locks before closing the port.
Why
Normal demo disconnect and reconnect attempts can reach
port.close()while both streams are still locked. The Web Serial specification requires those locks to be released before the port can close.Root cause
cancel()andabort()settle the streams but do not release their reader/writer locks.Impact
The demo can close and reconnect a serial device cleanly. Transport protocol behavior is unchanged.
Checks
link()implementation with standard Web Streams and a port that rejects close while locked.node --input-type=module --check.Built on #848.