fix(wasm): show macro storage capacity - #957
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Display
macro_space_sizeas bytes of macro storage in the Wasm demo's capability summary.Why
Every successful demo connection currently prints
undefined macrosbecauseDeviceCapabilitieshas nomax_macrosfield.Root cause
The demo referenced a capability name that is not present in the generated Wasm type.
Impact
Demo output now reports the capability the firmware actually sends. No protocol or firmware behavior changes.
Checks
macro_space_sizeand nomax_macrosfield exists.node --input-type=module --check.Built on #848.