Fix: Standardize Variable Naming Convention

[rmottanet]

This pull request implements comprehensive naming convention standardization by converting all local variables from UPPER_CASE to lower_case format. This addresses SonarCloud code quality warnings and establishes consistent shell scripting patterns throughout the codebase.

---

Changes Implemented:

• Naming Convention Standardization: Updated 7+ local variables from UPPER_CASE to lower_case naming:

  • REPO → repo
  • WORKSPACE → workspace
  • PROJECT → project
  • NOTIFICATION_ID → notification_id
  • OWNER → owner
  • QUERY → query
  • SLASH_ENCODED → slash_encoded

• Scope: Modified variables across all core modules:

  • GitHub Operations: Repository listing, search, and notification functions
  • GitLab Operations: Project and workspace management functions
  • Bitbucket Operations: Repository and workspace handling
  • Utility Functions: URL encoding and parameter processing

• Files Updated: Modified 12+ scripts across src/ directory to ensure consistent variable usage.

---

Technical Details:

Before (Inconsistent Convention)

local REPO="$1"
local OWNER="$2"
# ... mixed usage of UPPER_CASE and lower_case

After (Standardized Convention)

local repo="$1"
local owner="$2"
# ... consistent lower_case usage throughout

Shell Scripting Best Practices Applied:

1. local variables: lower_case_with_underscores
2. environment variables: UPPER_CASE (unchanged in this PR)
3. constants: UPPER_CASE (unchanged in this PR)
4. function names: lower_case_with_underscores (already compliant)

---

Benefits:

1. Improved Code Consistency

• Eliminates mixed naming conventions within and across scripts
• Follows Google Shell Style Guide and ShellCheck recommendations
• Makes codebase more predictable and easier to navigate

2. Enhanced Readability

• Clear visual distinction between local variables and environment variables
• Reduces cognitive load when scanning code
• Aligns with community standards for shell scripting

3. Better Maintainability

• Standardized patterns simplify future modifications
• Consistent naming reduces risk of variable shadowing conflicts
• Facilitates team collaboration with clear conventions

4. SonarCloud Compliance

• Addresses S117: Local variable naming convention warnings
• Improves maintainability score in quality gate analysis
• Demonstrates commitment to code quality standards

---

Motivation:

This standardization addresses a fundamental code quality issue identified by SonarCloud analysis. In shell scripting, consistent naming conventions are particularly important because:

1. Scope Clarity: Differentiating local variables (lower_case) from environment variables (UPPER_CASE) prevents confusion about variable scope and lifetime
2. Error Prevention: Clear conventions reduce the risk of accidentally overwriting important environment variables
3. Team Alignment: Established standards make the codebase more accessible to new contributors
4. Tool Integration: Consistent naming works better with linting tools, IDEs, and static analysis

The changes follow industry-standard shell scripting guidelines from:

• Google Shell Style Guide
• Shell static code analysis
• Bash Hackers Wiki best practices

---

Testing & Validation:

All scripts have been thoroughly tested to ensure:

• No breaking changes to functionality
• All variable references updated consistently
• Parameter passing and scope remain correct
• Script outputs and behaviors unchanged
• ShellCheck passes without naming convention warnings

The refactoring is purely syntactical - no functional behavior has been altered. The standardization creates a more professional, maintainable codebase that aligns with industry best practices for shell script development.

This completes the foundation for consistent code style across the entire GitNap project, making future development and maintenance more efficient and less error-prone.

🔗 https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&tags=naming&id=rmottanet_gitnap

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud