Fix fatal stale imports left by the Filament 4 resource restructure#135
Open
byjujohn wants to merge 2 commits into
Open
Fix fatal stale imports left by the Filament 4 resource restructure#135byjujohn wants to merge 2 commits into
byjujohn wants to merge 2 commits into
Conversation
… imports and unified Actions namespace Upstream main's F4 restructure moved ActivitylogResource into a nested namespace but left the Pages, RelationManager, and timeline action importing the old FQCN (fatal: class not found at boot). Also migrates the RelationManager form() to the Schema signature and table ->actions() to ->recordActions(), and swaps removed Filament\Tables\Actions classes for the unified Filament\Actions namespace. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AYdjTQC47Yzs6R1a5iCVaJ
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AYdjTQC47Yzs6R1a5iCVaJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Filament 4 restructure moved
ActivitylogResourceinto a nested namespace (Resources\ActivitylogResource\ActivitylogResource), but four files still import the old FQCN, which is now a namespace rather than a class — so booting any app with the plugin fatals withClass "Rmsramos\Activitylog\Resources\ActivitylogResource" not found.This PR:
Pages/ListActivitylog,Pages/ViewActivitylog, andActivitylogRelationManagerActivitylogRelationManagerto the Filament 4 APIs it was missed by:form(Schema): Schema,->recordActions(), and the unifiedFilament\Actions\ViewActionFilament\Tables\Actions\ActionforFilament\Actions\ActioninActivityLogTimelineTableActionilluminate/contractsto allow^13.0(no code changes were needed under Laravel 13)Running in production-shaped test suites (1,800+ tests) against Filament 4.11 and 5.6 on Laravel 12 and 13.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AYdjTQC47Yzs6R1a5iCVaJ