[codex] Move approvals into core policy modules#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the M6/M7 approval-domain refactor.
Changes include:
src/cli/chat/state/approval-rules.tsintosrc/core/approvals/remembered-rules.ts.src/cli/chat/state/approval-rules.tsas a TUI compatibility re-export only.src/core/approvals/:types.tspolicy-chain.tsdefault-policies.tssurface.tssrc/core/chat/tool-approval-host.tscompatibility path; all callers now import approval surface/types directly fromcore/approvals.tool-dispatchto evaluate ordered default approval policies for approval-required tools and outside-workspace inspection.Impact
Approval persistence, policy decisions, and host approval surfaces now have a core domain home. Existing approval UX and trace events are preserved, while future approval policies can be added as ordered policy functions instead of being embedded in host UI code.
Validation
yarn test:unit src/__tests__/unit/core/approval-policy-chain.test.tsyarn test:unit src/__tests__/unit/core/project-approval-rules.test.tsyarn test:unit src/__tests__/unit/tui/local-commands.test.tsyarn vitest run src/__tests__/integration/core/run-agent.test.tsyarn vitest run src/__tests__/integration/tools/tools.test.tsyarn eslintyarn typecheckyarn testoutside the sandbox, because the full integration suite needs localhost binding and normal git identity for temp repositories