Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts M10 and M11 chat turn orchestration phases:
turn-session.ts,turn-runtime.ts, andturn-tools.tsfor ordinary turn session/runtime/tool preparationturn-memory-maintenance.tsfor inline/background maintenance, trace appending, latest-turn event summary updates, and background failure trace eventsturn-persistence.tsfor final turn persistence orchestration and final-compaction running seed updatesordinary-turn.tsas high-level phase orchestration with lease cleanup still in thefinallypathsrc/core/chat/README.mdWhy
This advances the domain-module refactor by shrinking the ordinary chat turn harness into named core-only phase modules while preserving public turn behavior.
Validation
yarn test:unit src/__tests__/unit/core/chat-turn-runtime.test.tsyarn test:unit src/__tests__/unit/core/chat-turn-memory-maintenance.test.tsyarn vitest run src/__tests__/integration/memory/memory-integration.test.tsyarn vitest run src/__tests__/integration/chat/chat-runtime.test.tsyarn vitest run src/__tests__/integration/chat/session-submit.test.tsyarn vitest run src/__tests__/integration/core/agent-loop.test.tsyarn test:integrationoutside the sandboxyarn eslintyarn typecheckyarn build