Skip to content

[codex] Consolidate slash command boundaries#37

Merged
roackb2 merged 1 commit intomainfrom
codex/m115a-command-boundary-consolidation
May 2, 2026
Merged

[codex] Consolidate slash command boundaries#37
roackb2 merged 1 commit intomainfrom
codex/m115a-command-boundary-consolidation

Conversation

@roackb2
Copy link
Copy Markdown
Owner

@roackb2 roackb2 commented May 2, 2026

Summary

  • Move the slash command result contract into src/core/commands/slash/result-types.ts as SlashCommandResult.
  • Remove the old LocalCommandResult type from chat and avoid compatibility aliases or re-exports.
  • Make TUI local command autocomplete delegate to the core slash autocomplete helpers.
  • Update command domain README language to describe the current implementation.

Why

This is M11.5-A from the domain-module consolidation pass. The command domain now owns command result semantics, and the TUI no longer carries duplicate autocomplete logic beside the core helper.

Validation

  • yarn test:unit src/__tests__/unit/tui/local-commands.test.ts src/__tests__/unit/core/slash-commands.test.ts src/__tests__/unit/core/slash-command-modules.test.ts
  • yarn eslint
  • yarn typecheck

@roackb2 roackb2 marked this pull request as ready for review May 2, 2026 15:04
@roackb2 roackb2 merged commit c551bcb into main May 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant