Skip to content

[codex] Complete M11.5 consolidation#38

Merged
roackb2 merged 2 commits intomainfrom
codex/m115b-observability-activity-consolidation
May 2, 2026
Merged

[codex] Complete M11.5 consolidation#38
roackb2 merged 2 commits intomainfrom
codex/m115b-observability-activity-consolidation

Conversation

@roackb2
Copy link
Copy Markdown
Owner

@roackb2 roackb2 commented May 2, 2026

Summary

This PR completes the M11.5 consolidation pass from the domain-module retro. It turns the prior structural refactor into materially cleaner architecture instead of leaving thin wrappers and half-adopted seams.

  • Finish command-boundary cleanup already present on the branch: slash autocomplete delegates to core helpers, command result types live in the command domain, and command docs describe current behavior.
  • Consolidate observability/activity projection: remove duplicated tool summary logic, delete the one-line core/chat/trace-summary.ts wrapper, carry runId/step/timestamp correlation metadata through projected conversation activities, and keep TUI/web adapters on typed activity handler maps.
  • Make approval policy a real runtime extension seam: add approvalPolicies through runAgent, runAgentLoop, heartbeat, session submit, and ordinary chat turns; let built-in request policies be satisfied by remembered/custom policies before falling through to human approval; move TUI remembered approvals into the policy layer.
  • Make trace summarizer registration real in production: chat turn persistence can now use a supplied TraceSummarizerRegistry instead of always using the default summarizer.
  • Add import-boundary tests for core-to-host layering, command UI independence, and approval host independence.
  • Update approvals, observability, and chat docs to reflect the current ownership boundaries.

Why

The retro found that M0-M11 improved structure but did not fully reach the desired architectural outcome. This PR is the consolidation step: it removes fake seams, adopts the extension points in production paths, and adds guardrails so the same layering problems do not quietly return.

Validation

  • yarn test:unit
  • yarn typecheck
  • yarn eslint
  • yarn vitest run src/__tests__/integration/core/run-agent.test.ts
  • yarn vitest run src/__tests__/integration/web/control-plane-sessions-state.test.tsx
  • git diff --check

Note: earlier, yarn test:integration src/__tests__/integration/web/control-plane-sessions-state.test.tsx expanded to the full integration suite in this repo. The broader run failed in unrelated sandbox/setup areas: temp git commits without identity and daemon tests blocked from listening on 127.0.0.1. The exact web test passed when run directly with Vitest.

@roackb2 roackb2 marked this pull request as ready for review May 2, 2026 15:32
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 81eb71351c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/core/observability/trace-summarizers.ts
@roackb2 roackb2 force-pushed the codex/m115b-observability-activity-consolidation branch from 81eb713 to 44edfd2 Compare May 2, 2026 15:52
@roackb2 roackb2 changed the title [codex] Consolidate observability activity summaries [codex] Complete M11.5 consolidation May 2, 2026
@roackb2 roackb2 merged commit ccea392 into main May 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant