Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81eb71351c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
81eb713 to
44edfd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the M11.5 consolidation pass from the domain-module retro. It turns the prior structural refactor into materially cleaner architecture instead of leaving thin wrappers and half-adopted seams.
core/chat/trace-summary.tswrapper, carryrunId/step/timestampcorrelation metadata through projected conversation activities, and keep TUI/web adapters on typed activity handler maps.approvalPoliciesthroughrunAgent,runAgentLoop, heartbeat, session submit, and ordinary chat turns; let built-in request policies be satisfied by remembered/custom policies before falling through to human approval; move TUI remembered approvals into the policy layer.TraceSummarizerRegistryinstead of always using the default summarizer.Why
The retro found that M0-M11 improved structure but did not fully reach the desired architectural outcome. This PR is the consolidation step: it removes fake seams, adopts the extension points in production paths, and adds guardrails so the same layering problems do not quietly return.
Validation
yarn test:unityarn typecheckyarn eslintyarn vitest run src/__tests__/integration/core/run-agent.test.tsyarn vitest run src/__tests__/integration/web/control-plane-sessions-state.test.tsxgit diff --checkNote: earlier,
yarn test:integration src/__tests__/integration/web/control-plane-sessions-state.test.tsxexpanded to the full integration suite in this repo. The broader run failed in unrelated sandbox/setup areas: temp git commits without identity and daemon tests blocked from listening on127.0.0.1. The exact web test passed when run directly with Vitest.