Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the M11.6 chat-turn architecture-quality gate before moving to toolkits.
src/core/chat/turn-tools.tsmodule.turn-context.ts.session-turn-preflight.ts.turn-persistence.ts.src/core/chat/*imports from the public package root and add an import-boundary test to prevent recurrence.src/core/chat/README.mdto distinguish stable core entry points from internal turn services.Why
M11.6 is meant to be a quality gate, not a file shuffle. The chat turn path now leaves
ordinary-turn.tsas orchestration over behavior-owning services: context preparation, preflight, run loop, memory maintenance, persistence, and lease cleanup. Durable side effects now live with the lifecycle phase that owns them.Validation
yarn test:unit src/__tests__/unit/core/chat-turn-runtime.test.ts src/__tests__/unit/core/chat-turn-persistence.test.ts src/__tests__/unit/core/import-boundaries.test.tsyarn vitest run src/__tests__/integration/chat/chat-runtime.test.tsyarn vitest run src/__tests__/integration/chat/session-submit.test.ts src/__tests__/integration/memory/memory-integration.test.tsyarn typecheckyarn eslint