M15 candidate: harden conversation engine docs and conformance#47
M15 candidate: harden conversation engine docs and conformance#47
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c26ed6c579
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function findRemovedPathImportViolations(files: string[], removedPrefixes: string[]): string[] { | ||
| return files.flatMap((file) => { | ||
| const imports = readImports(file) | ||
| .filter((specifier) => removedPrefixes.some((prefix) => normalizeImportSpecifier(specifier).startsWith(prefix))); |
There was a problem hiding this comment.
Resolve relative import paths before removed-path checks
The new removed-path conformance test only catches specifiers that already start with core/chat/..., so it misses reintroductions via relative imports. For example, a production file under src/core/chat/engine/... could import a deleted module as ../trace.js; normalizeImportSpecifier leaves that as ../trace, which will never match prefixes like core/chat/trace, and the test still passes. This weakens the regression guard the commit is adding for deleted chat paths.
Useful? React with 👍 / 👎.
Summary
Verification
Notes