Merged
Conversation
📝 WalkthroughWalkthroughRelease workflow changed from tag-triggered to manual Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Maintainer
participant GitHubActions as "GitHub Actions\n(release workflow)"
participant VerifyScript as "verify-main-ci.js\n(GitHub API)"
participant GitHub as "GitHub API / Repo"
participant Registry as "npm Registry"
Maintainer->>GitHubActions: trigger workflow_dispatch(version)
GitHubActions->>GitHub: create GitHub App token / checkout main (ref: main)
GitHubActions->>VerifyScript: run verify-main-ci --repo --workflow --sha
VerifyScript->>GitHub: poll workflow runs for head_sha
GitHub-->>VerifyScript: return run status
VerifyScript-->>GitHubActions: success / failure
alt verified success
GitHubActions->>GitHub: optionally bump package.json, commit, create annotated tag, push (using app token)
GitHubActions->>Registry: check if `@roastcodes/ttdash`@RELEASE_VERSION exists
alt not exists
GitHubActions->>Registry: npm publish
Registry-->>GitHubActions: publish result
end
GitHubActions->>GitHub: create GitHub Release for RELEASE_TAG
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/release.yml:
- Around line 86-97: The CI gate's polling window is too short (currently
--retries 30 and --retry-delay-ms 10000 -> ~5 minutes); update the workflow step
named "Verify main CI succeeded" to increase the polling window by raising
either --retries (e.g., to 180) or --retry-delay-ms (e.g., to 30000) passed to
scripts/verify-main-ci.js so the verifier polls for a longer period before
failing; keep the flags (--repo, --workflow ci.yml, --branch main, --sha
"${MAIN_SHA}") unchanged and only adjust the --retries / --retry-delay-ms
values.
- Around line 47-70: The inline Node step can't see the shell-only
CURRENT_VERSION variable because it's not exported; export CURRENT_VERSION (and
ensure RELEASE_VERSION is exported) before running the heredoc Node block so
process.env.CURRENT_VERSION and process.env.RELEASE_VERSION are defined; update
the script that sets CURRENT_VERSION (the line that computes CURRENT_VERSION and
the node <<'NODE' block which uses semverPattern, parse and compare) to export
the variable to the environment (or pass it explicitly into the node process) so
the parse/compare logic sees the correct values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5b5b6d56-79f9-4720-b6a1-f38a349dec03
📒 Files selected for processing (9)
.github/workflows/release.ymlCHANGELOG.mdRELEASING.mdpackage.jsonscripts/tag-main-release.shscripts/verify-main-ci.jssrc/lib/constants.tsvite-env.d.tsvite.config.ts
💤 Files with no reviewable changes (2)
- package.json
- scripts/tag-main-release.sh
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/release.yml:
- Around line 173-175: The publish step "Publish package to npm" is missing the
NODE_AUTH_TOKEN required by the .npmrc created by actions/setup-node; update
that step (the step with name "Publish package to npm" and run: npm publish) to
set the environment variable NODE_AUTH_TOKEN from a repository secret (e.g., set
env: NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}) so npm publish can authenticate
successfully.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: eb418c93-853f-4912-9558-ca56a9269c47
📒 Files selected for processing (1)
.github/workflows/release.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Documentation
Chores