Conversation
The saturation plane that Color noise reduction blurs was never written under clear pixels (the luma plane beside it is), so the blur read whatever that memory held, and the pixels next to a transparent area came out differently from one run to the next. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
adjust_camera_raw_detailfills a saturation plane for Color noise reduction, but skipped clear pixels without writing them (the luma plane beside it writes 0). The box blur then read uninitializedmallocmemory, so pixels next to a transparent area came out differently from run to run, and could pick up garbage.Fix
Write 0 for clear pixels, as the luma plane does.
Test
CameraRawTests.colorNoiseReductionIgnoresWhatClearPixelsHeld: applies Color noise reduction to a picture with a clear band, dirties freed memory of the same size with saturated pixels, and applies it again: the two results must be identical. It failed on every run before the fix and passes after.🤖 Generated with Claude Code