object assign #547
Merged
object assign #547
+119
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
requested changes
Mar 28, 2025
Collaborator
There was a problem hiding this comment.
Thanks for the PR @harrisonho99 inline.go is actually generated by tools/gen-jscore so you'll need to update yaml templates to make the go generate test pass.
stevenh
requested changes
Mar 29, 2025
Collaborator
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Still a few differences on the generation. You can run it locally with go generate ./…
Contributor
Author
|
hi @stevenh i have updated, please check again |
stevenh
approved these changes
Mar 31, 2025
Collaborator
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Thanks for the PR look good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
built in object assign