Show account identity beside plan badge#439
Show account identity beside plan badge#439mrevanzak wants to merge 6 commits intorobinebers:mainfrom
Conversation
mrevanzak
requested review from
davidarny,
robinebers and
validatedev
as code owners
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d577a80ebe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR adds account identity display to provider cards by promoting Account text lines into the card header, and updates the Codex plugin to emit that identity from its auth state.
Changes:
- Render detected account identity beside the plan badge and remove duplicated
Accountrows from the body. - Add ProviderCard tests for header rendering and overview-filter interactions.
- Emit Codex account identity from
id_token/account_id, declare it in the manifest, and add plugin tests for refresh-driven identity updates.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/components/provider-card.tsx |
Extracts Account text lines into the header badge area and filters them from rendered body lines. |
src/components/provider-card.test.tsx |
Adds UI tests for account badge rendering and overview-filter behavior. |
plugins/codex/plugin.test.js |
Adds Codex tests for reading account identity from stored and refreshed tokens. |
plugins/codex/plugin.json |
Declares the new Account text line in the Codex manifest. |
plugins/codex/plugin.js |
Parses Codex id_token claims and emits an Account line alongside existing usage data. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This is really cool and paves the way for multiple accounts per provider. However, it would be great if we could toggle this feature on or off in the settings to avoid clutter. |
nice idea |
mrevanzak
force-pushed
the
show-account-identity
branch
from
8e42c6d to
7250a8c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a641658811
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, [scheduleTrayIconUpdate, setMenubarIconStyle]) | ||
|
|
||
| const handleShowAccountIdentityChange = useCallback((value: boolean) => { | ||
| track("setting_changed", { setting: "show_account_identity", value: String(value) }) |
There was a problem hiding this comment.
handleShowAccountIdentityChange calls track(...) but this module never imports or defines track, so toggling “Show account identity” can throw ReferenceError: track is not defined at runtime and abort the rest of the handler (state update/save). This affects users when they change that setting in Settings.
Useful? React with 👍 / 👎.
|
Actually we are not currently supporting multi-account workflows. What's your thinking about the beneficial aspects of the PR? |
Yes, I understand. I just want to know which account this app used to display the data. its a basic stuff tho |
Summary
Tests
Visual evidence
Closes #438
Summary by cubic
Show the account identity next to the plan badge in provider cards, with a setting to hide it. Codex now prefers email from the
id_tokenand updates identity after token refresh. Closes #438.id_tokenemail (email,profile.email, namespaced) withaccount_idas fallback; updates after token refresh.plugins/geminimanifest removes itsAccountline.Written for commit a641658. Summary will update on new commits.