Test sse by robinjesson · Pull Request #81 · robinjesson/my-budget-api

robinjesson · 2026-04-12T19:14:16Z

No description provided.

…fications

…nd notifications

…cture for chatId

…tgreSQL

… repository for message retrieval

…ration

… for SSE

robinjesson · 2026-04-12T19:14:25Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copilot

Pull request overview

Adds a new “conversation” capability to the MyBudget API, including message retrieval/creation endpoints and an SSE stream for real-time message delivery.

Changes:

Introduces Conversation/Message entities, repositories, mappers, business logic, adapter, and a new ConversationController with GET/POST + SSE endpoints.
Adds a new Tzatziki feature test for retrieving conversation messages (and 404 on unknown conversation).
Updates infra/config to support the new flow (Reactor dependency, ASYNC security dispatcher allowance, docker volume change, and JPA ddl-auto setting).

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/test/resources/features/conversation.feature	Adds BDD scenarios for conversation message retrieval and not-found behavior.
src/main/resources/application.yml	Changes Hibernate `ddl-auto` behavior.
src/main/java/fr/robinjesson/mybudgetapi/security/SecurityConfiguration.java	Permits ASYNC dispatcher type (needed for async/SSE dispatch).
src/main/java/fr/robinjesson/mybudgetapi/repository/UserRepository.java	Switches to `FineRepository` base.
src/main/java/fr/robinjesson/mybudgetapi/repository/MessageRepository.java	Adds repository for fetching messages by conversation.
src/main/java/fr/robinjesson/mybudgetapi/repository/ConversationRepository.java	Adds repository for conversations.
src/main/java/fr/robinjesson/mybudgetapi/mappers/MessageMapper.java	Adds MapStruct mapper for message -> response mapping.
src/main/java/fr/robinjesson/mybudgetapi/mappers/ConversationMapper.java	Adds MapStruct mapper for conversation -> response mapping.
src/main/java/fr/robinjesson/mybudgetapi/entities/MessageEntity.java	Introduces persisted message model with conversation/user relations.
src/main/java/fr/robinjesson/mybudgetapi/entities/ConversationEntity.java	Introduces persisted conversation model.
src/main/java/fr/robinjesson/mybudgetapi/businesses/UserBusiness.java	Adds helper to fetch the connected user entity.
src/main/java/fr/robinjesson/mybudgetapi/businesses/ConversationBusiness.java	Adds message retrieval and message creation business operations.
src/main/java/fr/robinjesson/mybudgetapi/api/response/MessageResponse.java	Defines message API response payload.
src/main/java/fr/robinjesson/mybudgetapi/api/response/ConversationResponse.java	Defines conversation API response payload.
src/main/java/fr/robinjesson/mybudgetapi/api/request/MessageRequest.java	Defines message creation request payload.
src/main/java/fr/robinjesson/mybudgetapi/api/ConversationController.java	New REST + SSE endpoints for conversations/messages.
src/main/java/fr/robinjesson/mybudgetapi/adapter/ConversationAdapter.java	Orchestrates mapping, business calls, and SSE notifications.
src/main/java/fr/robinjesson/mybudgetapi/adapter/ChatNotification.java	Implements reactive SSE publishing via Reactor sinks.
pom.xml	Adds `reactor-core` dependency to support reactive types.
docker-compose.yml	Switches Postgres persistence from bind mount to named volume.

Copilot · 2026-04-12T19:19:12Z

+      userUid: robinj
+    - text: Ça va bien, merci!
+      userUid: robinj


The response assertion uses userUid, but the API DTO (MessageResponse) currently serializes a nested user object (with uid/email). This scenario will not match the actual response shape; either update the expected YAML to assert user.uid, or change the message response contract to expose userUid (and adjust mapping accordingly).

Suggested change

userUid: robinj

- text: Ça va bien, merci!

userUid: robinj

user.uid: robinj

- text: Ça va bien, merci!

user.uid: robinj

Copilot · 2026-04-12T19:19:13Z

+
+@Repository
+public interface MessageRepository extends FineRepository<MessageEntity, Long> {
+    List<MessageEntity> findByConversationId(Long conversationId);


findByConversationId(...) does not define any ordering, but the feature test expects messages in a specific order. Repository results are not guaranteed to be stable without an explicit sort; consider adding an OrderBy (e.g., by id/timestamp.createdAt) either in the query method name or via Sort so tests and clients get deterministic ordering.

Suggested change

List<MessageEntity> findByConversationId(Long conversationId);

List<MessageEntity> findByConversationIdOrderByIdAsc(Long conversationId);

Copilot · 2026-04-12T19:19:13Z

+    public List<MessageEntity> findMessagesByConversationId(final Long conversationId) {
+        if (!conversationRepository.existsById(conversationId)) {
+            throw new NotFoundException("Conversation not found");
+        }
+        return messageRepository.findByConversationId(conversationId);
+    }


Message retrieval is not scoped to the connected user (only checks existsById), so any authenticated user could read messages from any conversation ID. Align with the rest of the codebase’s ownership checks by modeling conversation ownership/membership and querying by (conversationId, connectedUserUid) (or enforcing a membership check) before returning messages.

Copilot · 2026-04-12T19:19:14Z

+        if (!conversationRepository.existsById(conversationId)) {
+            throw new NotFoundException("Conversation not found");
+        }
+        return messageRepository.findByConversationId(conversationId);
+    }
+
+    public MessageEntity createMessageForUser(final Long conversationId, String text) {
+        final MessageEntity message = new MessageEntity();
+        message.setText(text);
+        message.setUser(userBusiness.findConnectedUser());
+        message.setConversation(conversationRepository.findConcreteById(conversationId));
+        return messageRepository.save(message);
+    }


Message creation is not authorized against conversation ownership/membership; findConcreteById(conversationId) only guarantees existence. This allows posting messages into any conversation ID as any authenticated user. Add a membership/ownership check tied to connectedUser.getUid() before allowing the save.

Suggested change

if (!conversationRepository.existsById(conversationId)) {

throw new NotFoundException("Conversation not found");

}

return messageRepository.findByConversationId(conversationId);

}

public MessageEntity createMessageForUser(final Long conversationId, String text) {

final MessageEntity message = new MessageEntity();

message.setText(text);

message.setUser(userBusiness.findConnectedUser());

message.setConversation(conversationRepository.findConcreteById(conversationId));

return messageRepository.save(message);

}

authorizeConnectedUserConversationAccess(conversationId);

return messageRepository.findByConversationId(conversationId);

}

public MessageEntity createMessageForUser(final Long conversationId, String text) {

final var connectedUser = userBusiness.findConnectedUser();

final var conversation = authorizeConnectedUserConversationAccess(conversationId);

final MessageEntity message = new MessageEntity();

message.setText(text);

message.setUser(connectedUser);

message.setConversation(conversation);

return messageRepository.save(message);

}

private Object authorizeConnectedUserConversationAccess(final Long conversationId) {

final var conversation = conversationRepository.findConcreteById(conversationId);

if (conversation == null) {

throw new NotFoundException("Conversation not found");

}

final var connectedUser = userBusiness.findConnectedUser();

final boolean isConversationMember = conversation.getUsers().stream()

.anyMatch(user -> user.getUid().equals(connectedUser.getUid()));

if (!isConversationMember) {

throw new NotFoundException("Conversation not found");

}

return conversation;

}

Copilot · 2026-04-12T19:19:14Z

+public record MessageResponse(
+        Long id,
+        String text,
+        UserResponse user,


MessageResponse currently includes UserResponse, which contains the user's email. Returning user emails in chat message payloads is likely unintended data exposure; consider returning only the user UID (or a dedicated lightweight author DTO) and updating the mapper accordingly.

Suggested change

UserResponse user,

String userUid,

Copilot · 2026-04-12T19:19:14Z

+    @PostMapping("/{conversationId}/messages")
+    public ResponseEntity<MessageResponse> createMessage(@PathVariable final Long conversationId, @RequestBody final MessageRequest messageRequest) {
+        return ResponseEntity.ok(conversationAdapter.createMessage(conversationId, messageRequest));
+    }


This POST endpoint creates a new message resource but returns 200 OK. Other controllers in this codebase return 201 CREATED for resource creation; consider returning CREATED_201 (and optionally a Location header) for consistency and correct HTTP semantics.

Copilot · 2026-04-12T19:19:14Z

+    @PostMapping("/{conversationId}/messages")
+    public ResponseEntity<MessageResponse> createMessage(@PathVariable final Long conversationId, @RequestBody final MessageRequest messageRequest) {
+        return ResponseEntity.ok(conversationAdapter.createMessage(conversationId, messageRequest));
+    }


MessageRequest.text has no validation and the controller method does not use @Valid, so empty/null messages can be persisted and broadcast. Consider adding @NotBlank on text and annotating the controller parameter with @Valid to enforce basic input validation.

Copilot · 2026-04-12T19:19:14Z

+    @GetMapping("/{conversationId}/messages")
+    public ResponseEntity<List<MessageResponse>> findMessagesByConversationId(@PathVariable final Long conversationId) {
+        return ResponseEntity.ok(conversationAdapter.findMessagesByConversationId(conversationId));
+    }
+
+    @PostMapping("/{conversationId}/messages")
+    public ResponseEntity<MessageResponse> createMessage(@PathVariable final Long conversationId, @RequestBody final MessageRequest messageRequest) {
+        return ResponseEntity.ok(conversationAdapter.createMessage(conversationId, messageRequest));
+    }
+
+    @Operation(hidden = true)
+    @GetMapping(value = "/{conversationId}/open", produces = MediaType.TEXT_EVENT_STREAM_VALUE)
+    public Flux<ServerSentEvent<MessageResponse>> openConnection(@PathVariable Long conversationId) {
+        return conversationAdapter.getMessageStream(conversationId);
+    }


This controller introduces new behaviors (message creation and SSE streaming) but the added feature test only covers message retrieval and 404. Add integration scenarios for POST /conversations/{id}/messages (including DB assertions) and for /conversations/{id}/open (at least connection/authorization behavior) to prevent regressions.

Copilot · 2026-04-12T19:19:15Z

+import java.math.BigDecimal;
+import java.time.LocalDate;
+


BigDecimal and LocalDate imports are unused in this entity and should be removed to keep the file clean and avoid IDE/compiler warnings.

Suggested change

import java.math.BigDecimal;

import java.time.LocalDate;

…ration

…nd expose Set-Cookie header

robinjesson added 8 commits April 11, 2026 22:41

feat: implement SSE controller and business logic for simulation noti…

414d7de

…fications

test: enhance SSE integration test to handle multiple message sends a…

bad17f7

…nd notifications

feat: refactor SSE implementation to use Flux and update request stru…

ef00b79

…cture for chatId

chore: update database configuration and modify Docker volume for Pos…

4497836

…tgreSQL

feat: implement conversation and message entities with controller and…

8c5b512

… repository for message retrieval

feat: add conversation management with message creation and SSE integ…

619ebd3

…ration

feat: add conversation management with message creation and SSE integ…

af5e105

…ration

feat: implement chat notification service and update message handling…

51f52a7

… for SSE

Copilot AI review requested due to automatic review settings April 12, 2026 19:14

Copilot started reviewing on behalf of robinjesson April 12, 2026 19:14 View session

Copilot AI reviewed Apr 12, 2026

View reviewed changes

robinjesson added 6 commits April 12, 2026 21:29

fix: remove unnecessary dispatcher type matcher from security configu…

f142bd5

…ration

feat: enhance security configuration with SameSite cookie attribute a…

8cdc8fa

…nd expose Set-Cookie header

feat: add TimestampResponse for message timestamps in MessageResponse

c0fd838

feat: implement conversation creation with participant management

04d5056

feat: add user retrieval functionality with findAll method

f300bb8

feat: add functionality to retrieve conversations for connected users

d5d0a38

Repository owner deleted a comment from Copilot AI Jun 7, 2026

Navigation Menu

Test sse - #81

Test sse#81
robinjesson wants to merge 14 commits into
developfrom
test-sse

robinjesson commented Apr 12, 2026

Uh oh!

robinjesson commented Apr 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Copilot AI Apr 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	List<MessageEntity> findByConversationId(Long conversationId);
	List<MessageEntity> findByConversationIdOrderByIdAsc(Long conversationId);

Conversation

robinjesson commented Apr 12, 2026

Uh oh!

robinjesson commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

robinjesson commented Apr 12, 2026 •

edited

Loading