Fix HKCAZ segement encoding and camtParser #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Nice work, I will merge it and create a new version after I have tested it with my banks soon. |
as19git67
changed the title
robocode13
approved these changes
Jan 23, 2026
Owner
robocode13
left a comment
robocode13
left a comment
There was a problem hiding this comment.
Tested successfully with 4 banks (DKB, Ing, Renault, Baader)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If more than iban and bic is specified in the HKCAZ segement, comdirect bank does not accept the message.
I've create a new DataGroup CamtAccount that is used instead of InternationalAccount.
comdirect bank also returns date elements that are differently formatted and also date time can be there. I've enhanced the camtParser.
In statementInteractionCAMT there is now detected if the xml is utf-8 encoded and if yes then it converts the message back to utf-8 so that German umlauts don't get lost.
Note that all my other banks are also tested with this PR: Raiffeisenbank, MLP Bank, ING and comdirect.