fix(ci): resolve TypeScript composite build failure and clean logger build artifacts - #7
Merged
Merged
Conversation
remove prepare hook running 'bun run build' during install which triggered tsc before referenced projects were built delete accidentally committed build artifacts from src (js and d.ts files) add logger project to root tsconfig references for explicit build ordering ensure clean builds succeed without dist or tsbuildinfo, matching CI environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request fixes the CI TypeScript build failure and cleans up the logger package structure to ensure consistent builds from a completely clean environment.
Changes
CI / Build Fix
preparescript frompackage.jsonbun run buildduringbun install, triggeringtsc -p .before referenced projects were builtTS6305errors in CI whendist/did not existLogger Package Cleanup
srcindex.jsindex.d.tslogger.jslogger.d.tsutils.jsutils.d.tsThese files were generated outputs and should not live next to the source
.tsfiles.TypeScript Configuration
libs/loggerto the roottsconfig.jsonproject referencestsc -bResult