ROB-1418 mcp stdio docs + loom#1839
Conversation
WalkthroughThe documentation for configuring remote MCP servers with HolmesGPT has been expanded with a new example section. This addition details how to use stdio-based MCP servers by converting them to SSE-compatible endpoints using Supergateway, including setup instructions for Docker and Kubernetes, and updated HolmesGPT configuration steps. Changes
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (7)
docs/configuration/holmesgpt/remote_mcp_servers.rst (7)
45-52: Fix heading punctuation and underline length
Remove the extra space before the colon in the section title and adjust the underline to match the new title length exactly for consistency with RST heading rules.-Example : Working with Stdio MCP servers -^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +Example: Working with stdio MCP servers +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
53-56: Improve list grammar and formatting
Add a comma and colon after the introductory phrase, then indent the bullet items consistently and remove trailing punctuation on links.-For this demo we will use - * `Dynatrace MCP <https://github.com/dynatrace-oss/dynatrace-mcp>`_ . - * `Supergateway <https://github.com/supercorp-ai/supergateway>`_ - runs MCP stdio-based servers over SSE. +For this demo, we will use: + + * `Dynatrace MCP <https://github.com/dynatrace-oss/dynatrace-mcp>`_ + * `Supergateway <https://github.com/supercorp-ai/supergateway>`_ – runs MCP stdio-based servers over SSE
57-58: Correct spelling and tone in the callout
Fix the misspelling of “Supergateway,” add the definite article, and improve phrasing.-Check out supergatway docs to find out other useful flags. +Check out the Supergateway docs to discover additional useful flags.
59-68: Consider replacing raw HTML with RST directives
Embedding raw HTML can hinder theming and responsiveness. You can use Sphinx’s image/link directives instead:**See it in action** .. image:: https://cdn.loom.com/sessions/thumbnails/1b290511b79942c7b1d672a2a4cde105-ed4eed3f9d70b125-full-play.gif :target: https://www.loom.com/share/1b290511b79942c7b1d672a2a4cde105 :alt: Live demo of Supergateway wrapping Dynatrace MCP
69-85: Capitalize and format the Docker instructions
Ensure sentences start with a capital letter and use inline code formatting for commands in prose. Also verify the code-block indentation aligns under the directive.- you can change `"npx -y @dynatrace-oss/dynatrace-mcp-server@latest /"` to your specific MCP. + You can change ``npx -y @dynatrace-oss/dynatrace-mcp-server@latest /`` to your specific MCP.
106-107: Remove pipe characters and use proper RST formatting
The leading|will render literally. Replace with standard paragraph text or an admonition.- | This will run dynatrace MCP server as a pod in your cluster. - | credentials are passed as env vars. + This will run the Dynatrace MCP server as a pod in your cluster. + Credentials are passed as environment variables.
157-158: Capitalize product name in the step header
Update “holmes” to “Holmes” and consider rephrasing for clarity.-2. Add MCP server to holmes config. +2. Add MCP server to Holmes configuration
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/configuration/holmesgpt/remote_mcp_servers.rst(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: run_tests
- GitHub Check: Deploy docs
🔇 Additional comments (1)
docs/configuration/holmesgpt/remote_mcp_servers.rst (1)
173-178: Holmes CLI config example looks good
The YAML snippet correctly demonstrates how to add an SSE endpoint undermcp_servers.
2 participants
Summary by CodeRabbit