Remove CLOUD_ROUTING#1862
Merged
moshemorad merged 2 commits intoJul 13, 2025
Merged
Conversation
## Walkthrough
The changes remove the `disableCloudRouting` configuration and all related logic, documentation, and validation from the codebase, Helm charts, and documentation. All references to the `CLOUD_ROUTING` environment variable and its conditional behavior are eliminated, resulting in a simplified and unified control flow for cloud routing and interactivity features.
## Changes
| File(s) | Change Summary |
|-----------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------|
| docs/configuration/alertmanager-integration/outofcluster-prometheus.rst | Removed step about enabling cloud-routing; renumbered and simplified alert sending instructions.|
| docs/setup-robusta/additional-settings.rst | Removed entire "Two-way Interactivity" section regarding cloud-routing and interactivity. |
| helm/robusta/templates/_helpers.tpl | Deleted validation logic that enforced `.Values.disableCloudRouting` when Robusta UI sink enabled.|
| helm/robusta/templates/runner.yaml | Removed conditional addition of `CLOUD_ROUTING` environment variable to runner container. |
| helm/robusta/values.yaml | Deleted `disableCloudRouting` configuration key and its comment. |
| src/robusta/integrations/receiver.py | Removed all logic and environment variable handling for `CLOUD_ROUTING` in the receiver logic. |
| src/robusta/runner/config_loader.py | Refactored receiver creation to use robusta sink directly; removed reliance on global config for account and cluster IDs. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant Helm
participant Robusta Runner
participant Receiver
User->>Helm: Install/Upgrade Robusta (no disableCloudRouting option)
Helm->>Robusta Runner: Deploy runner (no CLOUD_ROUTING env var)
Robusta Runner->>Receiver: Start receiver (no conditional disabling)
Receiver->>Receiver: Initialize incoming event receiver unconditionallyPossibly related PRs
Suggested reviewers
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/configuration/alertmanager-integration/outofcluster-prometheus.rst (1)
13-14: Use auto-numbered enumerations to avoid future renumbering painBecause the list items were re-ordered when
disableCloudRoutingwas removed, every downstream doc change will require manual renumbering. reStructuredText supports auto-numbering via#., which keeps the list correct regardless of insertions/removals.-1. Verify that all alerts contain a label named ``cluster_name`` or ``cluster``, matching the :ref:`cluster_name defined in Robusta's configuration <Global Config>`. This is necessary to identify which robusta-runner should receive alerts. -2. Edit the configuration for your centralized AlertManager: +#. Verify that all alerts contain a label named ``cluster_name`` or ``cluster``, matching the :ref:`cluster_name defined in Robusta's configuration <Global Config>`. This is necessary to identify which robusta-runner should receive alerts. +#. Edit the configuration for your centralized AlertManager:This tiny change eliminates manual bookkeeping and accidental numbering mistakes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
docs/configuration/alertmanager-integration/outofcluster-prometheus.rst(1 hunks)docs/setup-robusta/additional-settings.rst(0 hunks)helm/robusta/templates/_helpers.tpl(0 hunks)helm/robusta/templates/runner.yaml(0 hunks)helm/robusta/values.yaml(0 hunks)src/robusta/integrations/receiver.py(0 hunks)
💤 Files with no reviewable changes (5)
- helm/robusta/templates/runner.yaml
- helm/robusta/templates/_helpers.tpl
- helm/robusta/values.yaml
- docs/setup-robusta/additional-settings.rst
- src/robusta/integrations/receiver.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: run_tests
- GitHub Check: Pre-commit checks
- GitHub Check: Deploy docs
- GitHub Check: Deploy docs
🔇 Additional comments (1)
docs/configuration/alertmanager-integration/outofcluster-prometheus.rst (1)
13-14: No staledisableCloudRoutingreferences foundA full-text search across both the
docs/directory and the entire codebase returned zero matches fordisableCloudRoutingorCLOUD_ROUTING, confirming there are no remaining references to remove.
arikalon1
previously approved these changes
Jul 12, 2025
Contributor
arikalon1
left a comment
arikalon1
left a comment
There was a problem hiding this comment.
nice work
In the receiver, I would use the account_id from the robusta token, and not the one from the global config
To avoid the mismatch in configs
I would check if we can remove the account_id from globalConfig all together - since now, it depends on the ui sink
moshemorad
force-pushed
the
ROB-1590-remove-disable-cloud-routing-from-runner
branch
from
29f97dc to
54b08b3
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
docs/configuration/alertmanager-integration/outofcluster-prometheus.rst(1 hunks)docs/setup-robusta/additional-settings.rst(0 hunks)helm/robusta/templates/_helpers.tpl(0 hunks)helm/robusta/templates/runner.yaml(0 hunks)helm/robusta/values.yaml(0 hunks)src/robusta/integrations/receiver.py(2 hunks)src/robusta/runner/config_loader.py(1 hunks)
💤 Files with no reviewable changes (4)
- helm/robusta/values.yaml
- helm/robusta/templates/runner.yaml
- docs/setup-robusta/additional-settings.rst
- helm/robusta/templates/_helpers.tpl
🚧 Files skipped from review as they are similar to previous changes (2)
- docs/configuration/alertmanager-integration/outofcluster-prometheus.rst
- src/robusta/integrations/receiver.py
🧰 Additional context used
🪛 Ruff (0.11.9)
src/robusta/runner/config_loader.py
107-107: Undefined name RobustaSink
(F821)
🪛 Flake8 (7.2.0)
src/robusta/runner/config_loader.py
[error] 107-107: undefined name 'RobustaSink'
(F821)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: run_tests
- GitHub Check: run_tests
- GitHub Check: Deploy docs
🔇 Additional comments (2)
src/robusta/runner/config_loader.py (2)
87-93: LGTM: Improved receiver management with proper sink handling.The refactor to explicitly retrieve and use the first robusta sink is well-implemented. The early return with logging when no sinks are found provides good defensive programming.
96-96: LGTM: Consistent refactor to use robusta_sink properties.The changes correctly replace global config access with direct robusta_sink property access for
account_idandcluster_name. This aligns well with the removal of cloud routing conditional logic mentioned in the PR objectives.Also applies to: 99-100, 102-102, 105-105
stvnksslr
pushed a commit
to stvnksslr/robusta
that referenced
this pull request
Jul 20, 2025
* Remove CLOUD_ROUTING * Action request recieved using robusta sink account_id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.