feat: improve notification read management - #13
Open
AnthonyPoschen wants to merge 13 commits into
Open
Conversation
Improve the per-notification read affordance and page unread notifications in five-item windows.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d04d0d5404
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep the larger notification read target while reducing its idle contrast against the panel.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Center the notification page counter against its arrow controls.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Paginated notifications should expose page controls and bulk read, not the generic show-all button.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
AnthonyPoschen
marked this pull request as draft
August 24, 2026 09:33
Keep bulk read visible while notification data refreshes and remove the misleading open-link indicator from read-toggle rows.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Keep notification bulk and open controls visually consistent with other section footers.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Use a transparent idle background for notification read controls to match other buttons.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Make the notification read target a full-height trailing strip with only a left divider.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Match upstream bulk-read control readiness behavior while retaining notification pagination.\n\nValidation:\n- tests/panel-source-test.sh\n- tests/service-source-test.sh\n- tests/helper-test.sh\n- omarchy plugin validate .\n\nAssisted-by: Codex/GPT-5
Keep Mark all read visible until notifications are ready, and make the per-row read action a full-height attached strip. Also retain the matching bordered Open in GitHub control for assigned issues. Validation: - tests/panel-source-test.sh - tests/service-source-test.sh - tests/helper-test.sh - omarchy plugin validate . Assisted-by: Codex/GPT-5
Selecting the full-height read action now selects its parent row too, keeping hover feedback visually continuous. Validation: - tests/panel-source-test.sh - tests/service-source-test.sh - tests/helper-test.sh - omarchy plugin validate . Assisted-by: Codex/GPT-5
Optimistically clear notifications during bulk marking, restore them on failure, and retain the authoritative refresh after completion. Validation: - tests/service-source-test.sh - tests/panel-source-test.sh - tests/helper-test.sh - omarchy plugin validate . Assisted-by: Codex/GPT-5
AnthonyPoschen
marked this pull request as ready for review
August 24, 2026 11:50
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90062f9f35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Clear bulk-marked notifications in one model update and restore failed operations in their original order. Validation: - tests/service-source-test.sh - tests/panel-source-test.sh - tests/helper-test.sh - omarchy plugin validate . Assisted-by: Codex/GPT-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
Validation:
tests/panel-source-test.shtests/service-source-test.shtests/helper-test.shomarchy plugin validate .