Skip to content

fix(miniforge): pypy variant is no longer available on the latest version #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eitsupi merged 5 commits into from
May 23, 2025
Merged

fix(miniforge): pypy variant is no longer available on the latest version #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77e0102
test(miniforge): drop tests to install mambaforge
eitsupi May 23, 2025
e089aa8
fix: pypy was removed from miniforge in 2025
eitsupi May 23, 2025
cbf9866
test: update test
eitsupi May 23, 2025
ce3c0c4
test: fix tests
eitsupi May 23, 2025
2c97439
test: update base image tag
eitsupi May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/miniforge/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "Conda, Mamba (Miniforge)",
"id": "miniforge",
"version": "2.0.0",
"version": "2.0.1",
"description": "Installs Conda and Mamba package manager and Python3. conda-forge set as the default (and only) channel.",
"documentationURL": "https://github.com/rocker-org/devcontainer-features/tree/main/src/miniforge",
"options": {
Expand All @@ -20,7 +20,7 @@
"Miniforge-pypy3"
],
"default": "Miniforge3",
"description": "Select install CPython (3) or PyPy (-pypy3)."
"description": "Select install CPython (3) or PyPy (-pypy3, which is deprecated and no longer available after version 24.9.0)."
}
},
"installsAfter": [
Expand Down
14 changes: 0 additions & 14 deletions test/miniforge/mambaforge-pypy3.sh
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions test/miniforge/mambaforge.sh
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion test/miniforge/mambaforge-existing-conda.sh → test/miniforge/miniforge-existing-conda.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ set -e
source dev-container-features-test-lib

# Check that conda is installed
check "conda" conda --version
check "conda" conda --version

# Report result
reportResults
4 changes: 1 addition & 3 deletions test/miniforge/miniforge-pypy3.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@

set -e

LATEST_VERSION="$(git ls-remote --tags https://github.com/conda-forge/miniforge | grep -oP "[0-9]+\\.[0-9]+.[0-9]+" | sort -V | tail -n 1)"

# shellcheck source=/dev/null
source dev-container-features-test-lib

# Feature-specific tests
check "conda" conda --version | grep "$LATEST_VERSION"
check "conda" bash -c 'conda --version | grep "24.7.1"'

# Report result
reportResults
21 changes: 3 additions & 18 deletions test/miniforge/scenarios.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,15 @@
{
"mambaforge": {
"image": "debian:stable-slim",
"features": {
"miniforge": {
"variant": "Mambaforge"
}
}
},
"miniforge-pypy3": {
"image": "debian:stable-slim",
"features": {
"miniforge": {
"version": "24.7.1-2",
"variant": "Miniforge-pypy3"
}
}
},
"mambaforge-pypy3": {
"image": "debian:stable-slim",
"features": {
"miniforge": {
"variant": "Mambaforge-pypy3"
}
}
},
"mambaforge-existing-conda": {
"image": "jupyter/base-notebook",
"miniforge-existing-conda": {
"image": "quay.io/jupyter/base-notebook",
"features":{
"miniforge": {}
},
Expand Down