Kendi weather app#56
Open
kendigm wants to merge 1 commit into
Open
Conversation
Flashrob
suggested changes
Dec 18, 2023
| const [input, setInput] = useState(""); | ||
| const [data, setData] = useState({}); | ||
| const [cityName, setCityName] = useState(""); | ||
| const API_KEY = "7c52b0b346e3515a9d1950f5fd508f09"; |
There was a problem hiding this comment.
never hardcode your api keys into your code. This is a big security risk and can lead to you paying lots of dollars by someone else misusing this. Since this github repo is publicly available, you could face big issues with this if it was a google api key or something else that charges by number of requests.
Please revise https://bootcamp.rocketacademy.co/2-full-stack/2.2-advanced-react/2.2.7-environmental-variables
| `https://api.openweathermap.org/data/2.5/forecast?lat=${geoData.lat}&lon=${geoData.lon}&appid=${API_KEY}` | ||
| ) | ||
| .then((response) => { | ||
| setData(response.data.list[0].main); |
There was a problem hiding this comment.
I don't think this works, as you do not return the result of the axios request in the previous .then block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.