-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(server, nodes): add json lane #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
stepmikhaylov
wants to merge
2
commits into
develop
Choose a base branch
from
feat/json-lane
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| { | ||
| // | ||
| // Required: | ||
| // The displayable name of this node | ||
| // | ||
| "title": "Return JSON", | ||
| // | ||
| // Required: | ||
| // The protocol is the endpoint protocol | ||
| // | ||
| "protocol": "response_json://", | ||
| // | ||
| // Required: | ||
| // Class type of the node - what it does | ||
| // | ||
| "classType": ["infrastructure"], | ||
| // | ||
| // Required: | ||
| // Capabilities are flags that change the behavior of the underlying | ||
| // engine | ||
| // | ||
| "capabilities": [], | ||
| // | ||
| // Optional: | ||
| // Register is either filter, endpoint or ignored if not specified. If the | ||
| // type is specified, a factory is registered of that given type | ||
| // | ||
| "register": "filter", | ||
| // | ||
| // Optional: | ||
| // The node is the actual physical node to instantiate - if | ||
| // not specified, the protocol will be used | ||
| // | ||
| "node": "python", | ||
| // | ||
| // Optional: | ||
| // The path is the executable/script code - it is node dependent | ||
| // and is optional for most node | ||
| // | ||
| "path": "nodes.response", | ||
| // | ||
| // Required: | ||
| // The prefix map when added/removed when convertting URLs <=> paths | ||
| // | ||
| "prefix": "response", | ||
| // | ||
| // Optional: | ||
| // Description to of this driver | ||
| // | ||
| "description": ["A component that returns structured JSON data back to the requesting client. It handles ", "the response phase of the HTTP request-response cycle by returning the results as a JSON ", "object. This component ensures that data is transmitted efficiently and clearly to ", "the client, providing a standardized format for the response."], | ||
| // | ||
| // Optional: | ||
| // The icon is the icon to display in the UI for this node | ||
| // | ||
| "icon": "util-infrastructure.svg", | ||
| "documentation": "https://docs.rocketride.org", | ||
| // | ||
| // Optional: | ||
| // Rendering hints to the UI which indicate which fields of | ||
| // the configuration should be used to display information | ||
| "tile": [], | ||
| // | ||
| // Optional: | ||
| // As a pipe component, define what this pipe component takes | ||
| // and what it produces | ||
| // | ||
| "lanes": { | ||
| "json": [] | ||
| }, | ||
| // | ||
| // Optional: | ||
| // Profile section are configuration optoins used by the driver | ||
| // itself | ||
| // | ||
| "preconfig": { | ||
| // Define the values that will be merged into any profile configuration | ||
| // specified, unless the profile is 'absolute' | ||
| "default": "default", | ||
| // Defines profiles used with the "profile": key | ||
| "profiles": { | ||
| "default": {} | ||
| } | ||
| }, | ||
| // | ||
| // Optional: | ||
| // Local fields definitions - these define fields only for the | ||
| // current service. You may specify them here, or directly | ||
| // in the shape | ||
| // | ||
| "fields": { | ||
| "laneName": { | ||
| "type": "string", | ||
| "title": "Identifier key within result", | ||
| "minLength": 1, | ||
| "default": "json", | ||
| "maxLength": 32 | ||
| } | ||
| }, | ||
| // | ||
| // Required: | ||
| // Defines the fields (shape) of the service. Either source or target | ||
| // map be specified, or both, but at least one is required | ||
| // | ||
| "shape": [ | ||
| { | ||
| "section": "Pipe", | ||
| "title": "Return JSON", | ||
| "properties": ["laneName"] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regenerate node docs so the generated schema includes the new JSON variant.
Line 26/Line 35 documents
response_json://, but the generated schema block (Line 101-165) does not list aReturn JSONsection. Please runnodes:docs-generateand commit the regenerated README content.As per coding guidelines, documentation for node inputs/outputs/config must stay co-located and content between
<!-- ROCKETRIDE:GENERATED:PARAMS START -->and<!-- ROCKETRIDE:GENERATED:PARAMS END -->is generator-managed.Also applies to: 101-165
🤖 Prompt for AI Agents
Source: Coding guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed, recheck