expand import@ before applying other transformations#34
Open
drzraf wants to merge 6 commits intorockettheme:developfrom
Open
expand import@ before applying other transformations#34drzraf wants to merge 6 commits intorockettheme:developfrom
drzraf wants to merge 6 commits intorockettheme:developfrom
Conversation
mahagr
requested changes
May 14, 2022
mahagr
left a comment
mahagr
left a comment
There was a problem hiding this comment.
After a quick look, I found a few discussion points.
drzraf
force-pushed
the
import-first
branch
from
c05e6a5 to
31e0626
Compare
Author
|
rebase on top of |
Author
|
For the sake of my |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #18
The second commit fixes #33
The CI failure seems unrelated