Skip to content

Invaild option for build_pip_package #62

Description

@petronny

In build(),

    bazel-bin/tensorflow/tools/pip_package/build_pip_package --gpu "${srcdir}"/tmprocm

bazel-bin/tensorflow/tools/pip_package/build_pip_package is pointed to tensorflow/tools/pip_package/build_pip_package.sh.

However, build_pip_package.sh --help shows no --gpu option in its usage.

Usage:
./build_pip_package.sh [--src srcdir] [--dst dstdir] [options]
./build_pip_package.sh dstdir [options]

    --src                 prepare sources in srcdir
                              will use temporary dir if not specified

    --dst                 build wheel in dstdir
                              if dstdir is not set do not build, only prepare sources

  Options:
    --project_name <name> set project name to name
    --cpu                 build tensorflow_cpu
    --gpudirect           build tensorflow_gpudirect
    --rocm                build tensorflow_rocm
    --nightly_flag        build tensorflow nightly

Maybe it should be changed to --gpudirect or --rocm now.

And please also consider setting the srcdir for build_pip_package, or else it will use mktemp -d -t tmp.XXXXXXXXXX and break the build when /tmp is not big enough.
I guess "${srcdir}"/tmprocm is for dstdir. So the updated command may be like

bazel-bin/tensorflow/tools/pip_package/build_pip_package --src "${srcdir}"/tmprocm-src --dst "${srcdir}"/tmprocm --rocm

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions