Fix skill merge metadata drift#54
Merged
Merged
Conversation
aa8466d to
7ba1a03
Compare
7ba1a03 to
b328115
Compare
Owner
Author
|
Controller validation for final head
Final worker verification is running after the inline-trigger fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate-skills --conflict=mergewhile preserving manual content outside generated markersschema_hashfrom the same full-description schema surface used byskills listValidation
bun test tests/integration/generate-skills.test.ts tests/cli/skills.test.ts tests/cli/generate-skills.test.tsbun run typecheckmcp2cli skills listnow reportsopen-brain ok 44 toolsmcp2cli skills diff open-brainreports no changes detectedRollout note
This is needed for the Open Brain repo-facts contract rollout because the generated Open Brain mcp2cli bundle already contained
get_contract,upsert_repo_fact, andlist_repo_facts, but existing bundles regenerated with--conflict=mergekept old frontmatter and stayed falsely marked stale.