fix: Server credentials input ux#216
Merged
rodonisi merged 8 commits intoJun 19, 2026
Merged
Conversation
Refactor `CredentialsSettings` into smaller, focused widgets to enhance maintainability and readability. Improve the display of login status within the form, providing clearer feedback for loading, error, and successful login states, including a visual confirmation. The "Save" button is now explicitly disabled while a login attempt is in progress. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Uses `maybeWhen` to explicitly handle `AsyncValue` states (loading, error) for user and server data. This improves UI stability by preventing potential issues with `valueOrNull` during state transitions on the credentials settings page. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Previously, the catch block in CurrentUser.build() returned the cached user state on any error, masking authentication failures. When a user saved invalid credentials, the UI continued showing the green checkmark and logged-in user instead of the error state. - Remove the try/catch that swallowed auth errors with stale state - Auth errors now propagate correctly, setting currentUserProvider to AsyncError, which causes loginStatus to return .error - UI correctly shows red ✕ and 'Invalid credentials' label Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
BothaGideon
changed the title
rodonisi
reviewed
Jun 18, 2026
rodonisi
left a comment
rodonisi
left a comment
Owner
There was a problem hiding this comment.
Ohh quite nice you're tackling this, thanks! I've been putting away improving the login form for a while now :)
I've left some minor comments that could addressed
Synchronize iOS dependencies, including workmanager_apple, to reflect potential changes or updates made during development on this branch.
When the app launches offline, network errors (SocketException, TimeoutException) now fail immediately instead of retrying 3 times. This preserves the instant offline UX that existed before the invalid credentials fix. The retry logic now distinguishes between: - Network errors (offline) → fail fast, no retries - Missing credentials → fail fast, no retries - Transient server errors (5xx) → retry up to 3 times Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
@rodonisi Fixed the shorthands and checked the offline abilities. Please let me know if this is sufficient! |
Owner
|
Thanks a lot, LGTM :) |
rodonisi
reviewed
Jun 18, 2026
rodonisi
reviewed
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few enhancements, bugfixes and UX updates:
Credentials journey
BEFORE:
Screen.Recording.2026-06-18.at.13.17.45.mp4
AFTER:
Screen.Recording.2026-06-18.at.13.18.41.mp4