dont rely on behaviour of RangeInclusive after exhaustion - #30
Merged
Merged
Conversation
the current code heavily relied on the internal implementation of RangeInclusive, especially regarding its state post exhaustion, which according to official docs, is unspecified. relying on these unspecified internal implementation details is a bad idea, and the problems surfaced when the internal implementation actually changed, in rust-lang/rust#155114. suddenly, the tests didn't pass on nightly. so, change the implementation to avoid relying on internal implementation details of rust's stdlib, and instead design my own custom API for the inclusive range type which is separate from stdlib's one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the current code heavily relied on the internal implementation of RangeInclusive, especially regarding its state post exhaustion, which according to official docs, is unspecified.
relying on these unspecified internal implementation details is a bad idea, and the problems surfaced when the internal implementation actually changed, in rust-lang/rust#155114. suddenly, the tests didn't pass on nightly.
so, change the implementation to avoid relying on internal implementation details of rust's stdlib, and instead design my own custom API for the inclusive range type which is separate from stdlib's one.