Feature/cleanups - #31
Merged
Merged
Conversation
roeeshoshani
force-pushed
the
feature/cleanups
branch
from
August 3, 2026 22:37
25d895c to
34e1ac2
Compare
the typed range types only exist as iterator adapters for the existing range types which dont support iteration with custom index type. beyond iteration, they serve no purpose. the built in range types can be used with custom index types for all purposes other than iteration. so, rename the types and update their docs to indicate that they are only iterator adapters, and should not be used for anything else other than iteration. also, get rid of the TypedRangeInclusive type. it does not support iteration, and thus provides no benefit over the built-in RangeInclusive, which can already be used with custom types.
roeeshoshani
force-pushed
the
feature/cleanups
branch
from
August 3, 2026 23:17
3089c1a to
ecf8b82
Compare
roeeshoshani
force-pushed
the
feature/cleanups
branch
from
August 3, 2026 23:40
27535f7 to
32e35b9
Compare
roeeshoshani
force-pushed
the
feature/cleanups
branch
from
August 3, 2026 23:44
9bb34d8 to
32ac3d4
Compare
…e, especially for TypedRangeInclusiveIter with the exhausted field
roeeshoshani
force-pushed
the
feature/cleanups
branch
from
August 3, 2026 23:46
32ac3d4 to
41c6b55
Compare
…terator for TypedRangeIter
…h_panics_on_overflow_like_std
roeeshoshani
force-pushed
the
feature/cleanups
branch
from
August 4, 2026 00:25
cc09006 to
227f750
Compare
…nups related to the panic functions
…ize_hint may return `None` on usize overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.