decomp menushop - #77
Merged
Merged
Conversation
- decompiled five menushop functions:
func_801E5D28
func_801E5DBC
func_801E6ACC
func_801E6EB0
func_801E791C
- refactored three functions in order to use MenuDisplayConfig struct
func_801E6F60
func_801E8B60
func_801E9554
- created menushop header file for struct, variable and function declaration
- func_801E5D28: change D_801EB088 from a u8 array to a struct - func_801E8B60: change the first argument from a u8 array to a struct
dargor123
changed the title
dargor123
changed the title
- Decompiled func_801E6A68 - Renamed some structs and their attributes to be more descriptive - Added constants for the number of items in the shop, item prices, and item slots
- func_801E5C08 - func_801E6C3C - func_801E6E0C - func_801E7374 - func_801E7508
roengstrom
reviewed
Sep 7, 2026
roengstrom
left a comment
roengstrom
left a comment
Owner
There was a problem hiding this comment.
Nice, thanks for the PR! Just a minor thing, otherwise it looks good!
Co-authored-by: Robin Engström <robin.engstrom@wint.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.