Fix make expected command - #80
Merged
Merged
Conversation
3cedb3b made every unit's target the expected/ object unconditionally, which fails the report wherever that tree is absent -- CI has never had one. The fallback to the built object is back, so the report runs with or without expected/; --expected opts into the expected tree for the GUI. `make expected` (tools/objdiff/build_expected.py) assembles one object per C unit from splat's disassembly -- matchings/ and nonmatchings/ in address order plus the unit's data files -- and proves them by relinking every binary and comparing with the original. README step 6 points at it.
Report for SLUS_008.92 (15eff07 - 45e539d)Total code: 1178980 bytes (+17940 bytes) ✅ 84 new matches
...and 54 more new matches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.