Decomp effect 028 - #83
Merged
Merged
Conversation
Curaga's overlay, all 126 functions, with its own header for the storage and record types the unit publishes. Most of the engine came across from the two overlays already decompiled: the eight mesh emitters and the entry point are near-twins of effect_025's and effect_001's, and func_801A5D4C/func_801A5720 are this overlay's private copies of bc_object15's sprite packet setup and emitter. The rest is the Curaga script itself -- the draw list, the strand and trail geometry, the node spawner and the pose walker. The types the overlay works in are now named. A script's entity is an EffectEntity header plus a private tail, so the allocator hands back plain storage and each script declares its own record; EffectDrawScript and EffectTintScript are each exactly the size their func_801A0B5C call asks for. A pose step's 0xC8..0x144 is thirty-two per-frame tables stored as offsets, which func_801A8CE4 relocates once per effect. Along the way, three fields that shared code with battle were mistyped: BattleGfx's 0x14 is a small ordering table for screen overlays, not a glyph set, and BattleEffectSlot carries an SVECTOR at 0x1C whose Y is the origin a model's bounds are summed with. Correcting them touches effect_001 and effect_025, which read the same fields. gte_ldfcb joins inline_c.h: the far-colour load from three 8-bit components, scaled into the GTE's 1/16 units, which gte_ldfc does not cover.
Report for SLUS_008.92 (f29ce8d - b4274a3)Total code: 1253220 bytes (+40700 bytes) ✅ 129 new matches
...and 99 more new matches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decomp all functions in the Curaga effect