Decomp effect 052 - #85
Merged
Merged
Conversation
X-Potion runs the engine Curaga already carries, so 99 of its 118 functions are the library: nineteen units, listed in its own link order, and a symbol file that maps their names onto its addresses. Deriving that map is the whole of the work -- align unit by unit and position by position, because two functions of one unit can hash alike when they differ only in which sibling they call, and pair the relocation streams off against each other. 244 addresses paired with nothing left in conflict. What is X-Potion's own is the entry, a root dispatcher and seventeen script functions, and all but one of those are byte-identical to Curaga's or Cure's, so they came across with the addresses rewritten. Only the bank carve was written here. Its rings are Curaga's sizes, so its parameter header is the same two counts; what differs is the pool: X-Potion has no trailing-spark pool, which is why its entry sets up three where Curaga sets up four and its dispatcher drains three. Three things the overlay needed from its config. splat does not carve out a lone `jr ra` no-op, and three of them sit between script functions, so they are named in the symbol file or the binary comes out short and every later address shifts. The asset blob was declared from 0x9BF0, which swallowed the script dispatch tables; it starts at 0x9C68. And the jump tables carry the tail pad ASFLAGS suppress, so the pad between particlestep's and list's is declared.
The port left the entry taking its prototype from effect_028_entry.h, the overlay it was copied from. Both overlays declare the same signature under the same name, so it compiled and the binary matched -- nothing but reading the include would have shown it. X-Potion's entry now owns its declaration, the way the other three overlays' do.
Report for SLUS_008.92 (e3acf06 - 612fa36)Total code: 1293120 bytes (+39900 bytes) ✅ 163 new matches
...and 133 more new matches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decomp the entirety of the effect_052 overlay