Pre-promotion cleanup: fix URLs, add community health files#11
Merged
Pre-promotion cleanup: fix URLs, add community health files#11
Conversation
- Fix repo URLs in README.md, install.sh (luca-general-ledger → lucaV0.5) - Update GETTING_STARTED.md references from gl-mvp to lucaV0.5 - Remove MIT license badge (custom license coming later) - Add CONTRIBUTING.md, SECURITY.md, CHANGELOG.md - Add issue templates (bug report, feature request) and PR template - Rename luca-installation-guide (1).docx to remove download artifact Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Runs npm test with PostgreSQL 16 service container on pushes to main and pull requests. Enables status checks for branch protection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The knexfile reads TEST_DATABASE_URL for the test environment. Without it, the fallback password doesn't match the CI service container. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Integration tests need the chart of accounts, approval rules, transaction type mappings, and default admin user seeded before they can run. Without seeds, tests fail with foreign key violations (account codes not found in accounts table). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tests create chain files in 'chains/default' (the config default), but the MCP tool handlers read config.chainDir. Setting CHAIN_DIR to /tmp/test-chains in CI caused the handlers to look for chain files in a different directory than where the tests created them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The 'creates chain directory' test constructed a ChainWriter without the required getPeriodStatus callback, unlike all other tests that use the makeWriter() helper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The gl_get_transaction MCP tool queries transaction_lines with ORDER BY line_number, but the column was never added to the schema. This migration adds it so the query works without falling through to the catch handler. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…emoved The afterEach cleanup was failing with EACCES when removing nested chain directories because makeWritable only set 0o666 on entries (no execute bit for directories). Directories need 0o777 to be traversable and deletable by fs.rm. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
luca-general-ledgerrepo name orgl-mvpproject nameluca-installation-guide (1).docxto remove the download artifact suffixNot included (needs manual action)
.github/workflows/test.yml) — the PAT needsworkflowscope to push Actions files. The file is ready locally and can be pushed once the permission is added, or committed via the GitHub UI.AI-driven general ledger with cryptographic audit trail. Conversational accounting via 50 MCP tools for Claude.accounting,general-ledger,double-entry,ai,mcp,claude,typescript,postgresqlTest plan
roger296/lucaV0.5roger296/lucaV0.5lucaV0.5notgl-mvp