fix: fall back to defaultBaseUrl when no bootstrap stored#565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
bootstrapMode === "qr-or-url"guard that blockeddefaultBaseUrlfallback in the mobile shell.bootstrapModewas"qr-or-url"and no bootstrap was stored,getActiveServerUrl()returned empty string — so the built-in server URL from branding was never used.defaultBaseUrlfrom the brand config when no bootstrap is stored.Why it matters
The mobile app showed "Not configured" even when
brand.generated.jsonhad a validdefaultBaseUrl. Users had to paste a bootstrap link every time, instead of the app auto-connecting to the default server from branding.Verification
pnpm sync+pnpm open:iosrebuild works